Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2035713002: binding: Supports V8PrivateProperty::getOrUndefined. (Closed)

Created:
4 years, 6 months ago by Yuki
Modified:
4 years, 6 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Supports V8PrivateProperty::getOrUndefined. Adds getOrUndefined() as a fast version of get() for the clients that do not need to care about the difference between a) the private property has not yet been set, and b) the private property was intentionally set to undefined. BUG=616618 Committed: https://crrev.com/c6cada593b5b731a615f6d66f96586f37e86e2d4 Cr-Commit-Position: refs/heads/master@{#397401}

Patch Set 1 #

Patch Set 2 : Added function comments to explain the difference. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Yuki
Could you review this CL?
4 years, 6 months ago (2016-06-02 13:20:16 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-06-02 13:21:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2035713002/20001
4 years, 6 months ago (2016-06-02 13:24:18 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-02 14:55:46 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 14:56:58 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c6cada593b5b731a615f6d66f96586f37e86e2d4
Cr-Commit-Position: refs/heads/master@{#397401}

Powered by Google App Engine
This is Rietveld 408576698