Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1623)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

Issue 2035653006: [DevTools] Move Console to v8 inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: improved api a bit Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h
index b50bb20bf87b8990c120f10234fef71242b491a7..225646b88e3cda287e93c26d5cd133515931282e 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h
@@ -21,6 +21,7 @@ namespace blink {
class InjectedScript;
class RemoteObjectIdBase;
+class V8ConsoleAgentImpl;
class V8DebuggerAgentImpl;
class V8DebuggerImpl;
class V8HeapProfilerAgentImpl;
@@ -35,6 +36,7 @@ public:
V8DebuggerImpl* debugger() const { return m_debugger; }
V8InspectorSessionClient* client() const { return m_client; }
+ V8ConsoleAgentImpl* consoleAgent() { return m_consoleAgent.get(); }
V8DebuggerAgentImpl* debuggerAgent() { return m_debuggerAgent.get(); }
V8ProfilerAgentImpl* profilerAgent() { return m_profilerAgent.get(); }
V8RuntimeAgentImpl* runtimeAgent() { return m_runtimeAgent.get(); }
@@ -84,6 +86,7 @@ private:
std::unique_ptr<V8DebuggerAgentImpl> m_debuggerAgent;
std::unique_ptr<V8HeapProfilerAgentImpl> m_heapProfilerAgent;
std::unique_ptr<V8ProfilerAgentImpl> m_profilerAgent;
+ std::unique_ptr<V8ConsoleAgentImpl> m_consoleAgent;
std::vector<std::unique_ptr<V8InspectorSession::Inspectable>> m_inspectedObjects;
};

Powered by Google App Engine
This is Rietveld 408576698