Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2035653006: [DevTools] Move Console to v8 inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: improved api a bit Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp
index ddfaa80a4792184737db245305c3f64f192ce01d..0237c178a90d10d43bb4150ec865e83db8984ccb 100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -5206,7 +5206,7 @@ void Document::addConsoleMessage(ConsoleMessage* consoleMessage)
if (!m_frame)
return;
- if (!consoleMessage->messageId() && !consoleMessage->relatedMessageId() && consoleMessage->location()->isUnknown()) {
+ if (consoleMessage->location()->isUnknown()) {
// TODO(dgozman): capture correct location at call places instead.
unsigned lineNumber = 0;
if (!isInDocumentWrite() && scriptableDocumentParser()) {
@@ -5214,7 +5214,7 @@ void Document::addConsoleMessage(ConsoleMessage* consoleMessage)
if (parser->isParsingAtLineNumber())
lineNumber = parser->lineNumber().oneBasedInt();
}
- consoleMessage = ConsoleMessage::create(consoleMessage->source(), consoleMessage->level(), consoleMessage->message(), SourceLocation::create(url().getString(), lineNumber, 0, nullptr), consoleMessage->scriptArguments());
+ consoleMessage = ConsoleMessage::create(consoleMessage->source(), consoleMessage->level(), consoleMessage->message(), SourceLocation::create(url().getString(), lineNumber, 0, nullptr));
}
m_frame->console().addMessage(consoleMessage);
}
« no previous file with comments | « third_party/WebKit/Source/core/core_generated.gypi ('k') | third_party/WebKit/Source/core/frame/DOMWindow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698