Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp

Issue 2035653006: [DevTools] Move Console to v8 inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: all tests pass Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
diff --git a/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp b/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
index ca14f5f90c8990959ce0786cbb1b40c58a5d2a08..eb145f4e401838d0d0deae9a8fa601ad33b6787b 100644
--- a/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
+++ b/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
@@ -31,9 +31,7 @@
#include "core/inspector/WorkerInspectorController.h"
#include "core/InstrumentingAgents.h"
-#include "core/inspector/InspectorConsoleAgent.h"
#include "core/inspector/InspectorInstrumentation.h"
-#include "core/inspector/WorkerConsoleAgent.h"
#include "core/inspector/WorkerThreadDebugger.h"
#include "core/workers/WorkerGlobalScope.h"
#include "core/workers/WorkerReportingProxy.h"
@@ -69,7 +67,6 @@ void WorkerInspectorController::connectFrontend()
// sessionId will be overwritten by WebDevToolsAgent::sendProtocolNotification call.
m_session = new InspectorSession(this, nullptr, m_instrumentingAgents.get(), 0, true /* autoFlush */, m_debugger->debugger(), m_debugger->contextGroupId(), nullptr);
- m_session->append(new WorkerConsoleAgent(m_session->v8Session(), m_workerGlobalScope));
}
void WorkerInspectorController::disconnectFrontend()
@@ -100,6 +97,11 @@ void WorkerInspectorController::resumeStartup()
m_workerGlobalScope->thread()->stopRunningDebuggerTasksOnPauseOnWorkerThread();
}
+void WorkerInspectorController::consoleEnabled()
+{
+ m_workerGlobalScope->thread()->workerReportingProxy().postWorkerConsoleAgentEnabled();
+}
+
void WorkerInspectorController::sendProtocolMessage(int sessionId, int callId, const String& response, const String& state)
{
// Worker messages are wrapped, no need to handle callId or state.

Powered by Google App Engine
This is Rietveld 408576698