Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/Source/core/inspector/ThreadDebugger.h

Issue 2035653006: [DevTools] Move Console to v8 inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: all tests pass Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/ThreadDebugger.h
diff --git a/third_party/WebKit/Source/core/inspector/ThreadDebugger.h b/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
index 3c2aa53667629576172fdcb9a450b81de3097127..90d69a40dfa09beef4b311aa4061fbb21a41a07a 100644
--- a/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
+++ b/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
@@ -40,7 +40,6 @@ public:
double currentTimeMS() override;
bool isInspectableHeapObject(v8::Local<v8::Object>) override;
void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>) override;
- void reportMessageToConsole(v8::Local<v8::Context>, MessageType, MessageLevel, const String16& message, const v8::FunctionCallbackInfo<v8::Value>* arguments, unsigned skipArgumentCount) final;
void consoleTime(const String16& title) override;
void consoleTimeEnd(const String16& title) override;
void consoleTimeStamp(const String16& title) override;
@@ -49,9 +48,9 @@ public:
V8Debugger* debugger() const { return m_debugger.get(); }
virtual bool isWorker() { return true; }
+
protected:
void createFunctionProperty(v8::Local<v8::Context>, v8::Local<v8::Object>, const char* name, v8::FunctionCallback, const char* description);
- virtual void reportMessageToConsole(v8::Local<v8::Context>, ConsoleMessage*) = 0;
void onTimer(Timer<ThreadDebugger>*);
v8::Isolate* m_isolate;

Powered by Google App Engine
This is Rietveld 408576698