Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 2035653006: [DevTools] Move Console to v8 inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: all tests pass Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (C) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 #include "core/inspector/InspectorMemoryAgent.h" 48 #include "core/inspector/InspectorMemoryAgent.h"
49 #include "core/inspector/InspectorNetworkAgent.h" 49 #include "core/inspector/InspectorNetworkAgent.h"
50 #include "core/inspector/InspectorPageAgent.h" 50 #include "core/inspector/InspectorPageAgent.h"
51 #include "core/inspector/InspectorResourceContainer.h" 51 #include "core/inspector/InspectorResourceContainer.h"
52 #include "core/inspector/InspectorResourceContentLoader.h" 52 #include "core/inspector/InspectorResourceContentLoader.h"
53 #include "core/inspector/InspectorTaskRunner.h" 53 #include "core/inspector/InspectorTaskRunner.h"
54 #include "core/inspector/InspectorTracingAgent.h" 54 #include "core/inspector/InspectorTracingAgent.h"
55 #include "core/inspector/InspectorWorkerAgent.h" 55 #include "core/inspector/InspectorWorkerAgent.h"
56 #include "core/inspector/LayoutEditor.h" 56 #include "core/inspector/LayoutEditor.h"
57 #include "core/inspector/MainThreadDebugger.h" 57 #include "core/inspector/MainThreadDebugger.h"
58 #include "core/inspector/PageConsoleAgent.h"
59 #include "core/layout/api/LayoutViewItem.h" 58 #include "core/layout/api/LayoutViewItem.h"
60 #include "core/page/FocusController.h" 59 #include "core/page/FocusController.h"
61 #include "core/page/Page.h" 60 #include "core/page/Page.h"
62 #include "modules/accessibility/InspectorAccessibilityAgent.h" 61 #include "modules/accessibility/InspectorAccessibilityAgent.h"
63 #include "modules/cachestorage/InspectorCacheStorageAgent.h" 62 #include "modules/cachestorage/InspectorCacheStorageAgent.h"
64 #include "modules/device_orientation/DeviceOrientationInspectorAgent.h" 63 #include "modules/device_orientation/DeviceOrientationInspectorAgent.h"
65 #include "modules/indexeddb/InspectorIndexedDBAgent.h" 64 #include "modules/indexeddb/InspectorIndexedDBAgent.h"
66 #include "modules/storage/InspectorDOMStorageAgent.h" 65 #include "modules/storage/InspectorDOMStorageAgent.h"
67 #include "modules/webdatabase/InspectorDatabaseAgent.h" 66 #include "modules/webdatabase/InspectorDatabaseAgent.h"
68 #include "platform/RuntimeEnabledFeatures.h" 67 #include "platform/RuntimeEnabledFeatures.h"
(...skipping 311 matching lines...) Expand 10 before | Expand all | Expand 10 after
380 m_session->append(cssAgent); 379 m_session->append(cssAgent);
381 380
382 m_session->append(new InspectorAnimationAgent(m_inspectedFrames.get(), m_dom Agent, cssAgent, m_session->v8Session())); 381 m_session->append(new InspectorAnimationAgent(m_inspectedFrames.get(), m_dom Agent, cssAgent, m_session->v8Session()));
383 382
384 m_session->append(InspectorMemoryAgent::create()); 383 m_session->append(InspectorMemoryAgent::create());
385 384
386 m_session->append(InspectorApplicationCacheAgent::create(m_inspectedFrames.g et())); 385 m_session->append(InspectorApplicationCacheAgent::create(m_inspectedFrames.g et()));
387 386
388 m_session->append(InspectorIndexedDBAgent::create(m_inspectedFrames.get())); 387 m_session->append(InspectorIndexedDBAgent::create(m_inspectedFrames.get()));
389 388
390 m_session->append(new PageConsoleAgent(m_session->v8Session(), m_domAgent, m _inspectedFrames.get()));
391
392 InspectorWorkerAgent* workerAgent = new InspectorWorkerAgent(m_inspectedFram es.get()); 389 InspectorWorkerAgent* workerAgent = new InspectorWorkerAgent(m_inspectedFram es.get());
393 m_session->append(workerAgent); 390 m_session->append(workerAgent);
394 391
395 InspectorTracingAgent* tracingAgent = InspectorTracingAgent::create(this, wo rkerAgent, m_inspectedFrames.get()); 392 InspectorTracingAgent* tracingAgent = InspectorTracingAgent::create(this, wo rkerAgent, m_inspectedFrames.get());
396 m_tracingAgent = tracingAgent; 393 m_tracingAgent = tracingAgent;
397 m_session->append(tracingAgent); 394 m_session->append(tracingAgent);
398 395
399 m_session->append(new InspectorDOMDebuggerAgent(isolate, m_domAgent, m_sessi on->v8Session())); 396 m_session->append(new InspectorDOMDebuggerAgent(isolate, m_domAgent, m_sessi on->v8Session()));
400 397
401 m_session->append(InspectorInputAgent::create(m_inspectedFrames.get())); 398 m_session->append(InspectorInputAgent::create(m_inspectedFrames.get()));
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
587 if (m_overlay) 584 if (m_overlay)
588 m_overlay->suspend(); 585 m_overlay->suspend();
589 } 586 }
590 587
591 void WebDevToolsAgentImpl::profilingStopped() 588 void WebDevToolsAgentImpl::profilingStopped()
592 { 589 {
593 if (m_overlay) 590 if (m_overlay)
594 m_overlay->resume(); 591 m_overlay->resume();
595 } 592 }
596 593
594 void WebDevToolsAgentImpl::consoleCleared()
595 {
596 if (m_domAgent)
597 m_domAgent->releaseDanglingNodes();
598 }
599
597 void WebDevToolsAgentImpl::pageLayoutInvalidated(bool resized) 600 void WebDevToolsAgentImpl::pageLayoutInvalidated(bool resized)
598 { 601 {
599 if (m_overlay) 602 if (m_overlay)
600 m_overlay->pageLayoutInvalidated(resized); 603 m_overlay->pageLayoutInvalidated(resized);
601 } 604 }
602 605
603 void WebDevToolsAgentImpl::setPausedInDebuggerMessage(const String& message) 606 void WebDevToolsAgentImpl::setPausedInDebuggerMessage(const String& message)
604 { 607 {
605 if (m_overlay) 608 if (m_overlay)
606 m_overlay->setPausedInDebuggerMessage(message); 609 m_overlay->setPausedInDebuggerMessage(message);
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
663 bool WebDevToolsAgent::shouldInterruptForMethod(const WebString& method) 666 bool WebDevToolsAgent::shouldInterruptForMethod(const WebString& method)
664 { 667 {
665 return method == "Debugger.pause" 668 return method == "Debugger.pause"
666 || method == "Debugger.setBreakpoint" 669 || method == "Debugger.setBreakpoint"
667 || method == "Debugger.setBreakpointByUrl" 670 || method == "Debugger.setBreakpointByUrl"
668 || method == "Debugger.removeBreakpoint" 671 || method == "Debugger.removeBreakpoint"
669 || method == "Debugger.setBreakpointsActive"; 672 || method == "Debugger.setBreakpointsActive";
670 } 673 }
671 674
672 } // namespace blink 675 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698