third_party/WebKit/Source/devtools/PRESUBMIT.py - Issue 2035653005: DevTools: split protocol.json into files per domain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/PRESUBMIT.py

Issue 2035653005: DevTools: split protocol.json into files per domain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/PRESUBMIT.py

diff --git a/third_party/WebKit/Source/devtools/PRESUBMIT.py b/third_party/WebKit/Source/devtools/PRESUBMIT.py

index 5baa6cd1c720dd96b2b21bfd1fdce203a6968bf5..f74063724c532a90b8fe454df280bd34fbbc81f0 100644

--- a/third_party/WebKit/Source/devtools/PRESUBMIT.py

+++ b/third_party/WebKit/Source/devtools/PRESUBMIT.py

@@ -71,7 +71,8 @@ def _CompileDevtoolsFrontend(input_api, output_api):

if (any(devtools_front_end in path for path in local_paths) or

any("protocol.json" in path for path in local_paths) or

any("compile_frontend.py" in path for path in local_paths) or

- any("InjectedScriptSource.js" in path for path in local_paths)):

+ any("InjectedScriptSource.js" in path for path in local_paths) or

+ any("DebuggerScript.js" in path for path in local_paths)):

lint_path = input_api.os_path.join(input_api.PresubmitLocalPath(),

"scripts", "compile_frontend.py")

out, _ = input_api.subprocess.Popen(

« no previous file with comments | « third_party/WebKit/Source/devtools/Inspector-1.1.json ('k') | third_party/WebKit/Source/devtools/devtools.gyp » ('j') | no next file with comments »