Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1049)

Unified Diff: third_party/WebKit/Source/core/inspector/BUILD.gn

Issue 2035653005: DevTools: split protocol.json into files per domain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/BUILD.gn
diff --git a/third_party/WebKit/Source/core/inspector/BUILD.gn b/third_party/WebKit/Source/core/inspector/BUILD.gn
index f739bbad9700e87ace888f1f10009bbed1e4e414..6f6ce87784418999e878c67cb560fc5a43e82a99 100644
--- a/third_party/WebKit/Source/core/inspector/BUILD.gn
+++ b/third_party/WebKit/Source/core/inspector/BUILD.gn
@@ -5,8 +5,6 @@
import("//third_party/WebKit/Source/bindings/bindings.gni")
import("//third_party/WebKit/Source/core/core.gni")
-visibility = [ "//third_party/WebKit/Source/*" ]
-
action("instrumentation_sources") {
script = "CodeGeneratorInstrumentation.py"
@@ -32,17 +30,18 @@ action("instrumentation_sources") {
# inspector protocol -----------------------------------------------------------
-protocol_file = "../../devtools/protocol.json"
-
action("protocol_sources") {
script = "../../platform/inspector_protocol/CodeGenerator.py"
+ deps = [
+ ":protocol_version",
+ ]
sources = [
"../../platform/inspector_protocol/CodeGenerator.py",
+ "../../platform/inspector_protocol/TypeBuilder_cpp.template",
+ "../../platform/inspector_protocol/TypeBuilder_h.template",
]
inputs = [
- protocol_file,
- "../../platform/inspector_protocol/TypeBuilder_h.template",
- "../../platform/inspector_protocol/TypeBuilder_cpp.template",
+ "browser_protocol.json",
]
outputs = [
"$blink_core_output_dir/inspector/protocol/Accessibility.cpp",
@@ -100,9 +99,10 @@ action("protocol_sources") {
]
args = [
- rebase_path(protocol_file, root_build_dir),
- "--domains",
- "Accessibility,Animation,ApplicationCache,CacheStorage,Console,CSS,Database,DeviceOrientation,DOM,DOMDebugger,DOMStorage,Emulation,IndexedDB,Input,Inspector,IO,LayerTree,Memory,Network,Page,Rendering,Security,ServiceWorker,Storage,Tracing,Worker",
+ "--protocol",
+ rebase_path("browser_protocol.json", root_build_dir),
+ "--include",
+ rebase_path("../../platform/v8_inspector/js_protocol.json", root_build_dir),
"--string_type",
"String",
"--export_macro",
@@ -113,3 +113,23 @@ action("protocol_sources") {
"core/inspector/protocol",
]
}
+
+action("protocol_version") {
+ script =
+ "../../platform/inspector_protocol/generate-inspector-protocol-version"
+
+ inputs = [
+ "browser_protocol.json",
+ ]
+ output_file = "$blink_core_output_dir/inspector/protocol.json"
+ outputs = [
+ output_file,
+ ]
+
+ args = [
+ "--o",
+ rebase_path(output_file, root_build_dir),
+ rebase_path("browser_protocol.json", root_build_dir),
+ rebase_path("../../platform/v8_inspector/js_protocol.json", root_build_dir),
+ ]
+}

Powered by Google App Engine
This is Rietveld 408576698