Introduce error handling in QuicHttpStream on UploadDataStream::Read() failure.

net/quic/quic_http_stream.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_http_stream.h"
 
 #include "base/callback_helpers.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/string_split.h"
 #include "base/strings/stringprintf.h"
@@ skipping 650 matching lines @@
 int QuicHttpStream::DoReadRequestBody() {
   next_state_ = STATE_READ_REQUEST_BODY_COMPLETE;
   return request_body_stream_->Read(
       raw_request_body_buf_.get(), raw_request_body_buf_->size(),
       base::Bind(&QuicHttpStream::OnIOComplete, weak_factory_.GetWeakPtr()));
 }
 
 int QuicHttpStream::DoReadRequestBodyComplete(int rv) {
   // |rv| is the result of read from the request body from the last call to
   // DoSendBody().
-  if (rv < 0)
+  if (rv < 0) {
+    if (!callback_.is_null())
+      DoCallback(rv);

[mmenke, 2016/06/02 15:17:58]

I don't think you need to invoke the callback here - it looks like this class is
designed to work much like HttpStreamParser, so I think you can just return rv
here

[maksims (do not use this acc), 2016/06/03 09:40:31]

Done.

+    stream_->Reset(QUIC_ERROR_PROCESSING_STREAM);
     return rv;
+  }
 
   // If the stream is already closed, don't continue.
   if (!stream_)
     return response_status_;

[mmenke, 2016/06/02 15:17:58]

This should go before the rv check - if this happens, the stream is already
destroyed, so stream_->Reset will crash if you try to call it.

[maksims (do not use this acc), 2016/06/03 09:40:31]

Done.

 
   request_body_buf_ = new DrainableIOBuffer(raw_request_body_buf_.get(), rv);
   if (rv == 0) {  // Reached the end.
     DCHECK(request_body_stream_->IsEOF());
   }
 
   next_state_ = STATE_SEND_BODY;
   return OK;
 }
 
@@ skipping 85 matching lines @@
   closed_stream_sent_bytes_ = stream_->stream_bytes_written();
   stream_ = nullptr;
 
   // If |request_body_stream_| is non-NULL, Reset it, to abort any in progress
   // read.
   if (request_body_stream_)
     request_body_stream_->Reset();
 }
 
 }  // namespace net