third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h - Issue 2035623002: Implement the script parts of custom element upgrade steps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

Issue 2035623002: Implement the script parts of custom element upgrade steps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ce-upgrade-in-document-dom-merge2

Patch Set: Do not assign in conditional to unbreak windows builder. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/custom-elements/spec/define-element.html ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp » ('j') | third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

index 9cdfc997d863c735821bc09c365a78a3d3abd930..a71ffff32545f795df1a0376b6a84ec4d321964e 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

@@ -6,16 +6,17 @@

#define ScriptCustomElementDefinition_h

#include "bindings/core/v8/ScopedPersistent.h"

+#include "bindings/core/v8/ScriptState.h"

#include "core/CoreExport.h"

#include "core/dom/custom/CustomElementDefinition.h"

#include "v8.h"

#include "wtf/Noncopyable.h"

+#include "wtf/RefPtr.h"

namespace blink {

class CustomElementDescriptor;

class CustomElementsRegistry;

-class ScriptState;

class CORE_EXPORT ScriptCustomElementDefinition final :

public CustomElementDefinition {

@@ -47,6 +48,7 @@ private:

// Implementations of |CustomElementDefinition|

ScriptValue getConstructorForScript() final;

+ bool runConstructor(Element*) override;

RefPtr<ScriptState> m_scriptState;

ScopedPersistent<v8::Object> m_constructor;