third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h - Issue 2035623002: Implement the script parts of custom element upgrade steps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

Issue 2035623002: Implement the script parts of custom element upgrade steps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ce-upgrade-in-document-dom-merge2

Patch Set: Feedback. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

index d922f14ab952b1e2e459d266063fa5011bb16776..fb46146a12422198b4964149c9e4ca49ee22a1ac 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

@@ -44,9 +44,7 @@ public:

void upgrade(Element*);

protected:

- // TODO(dominicc): Make this pure virtual when the script side is

- // implemented.

- virtual bool runConstructor(Element*);

+ virtual bool runConstructor(Element*) = 0;

private:

const CustomElementDescriptor m_descriptor;