Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

Issue 2035623002: Implement the script parts of custom element upgrade steps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ce-upgrade-in-document-dom-merge2
Patch Set: Do not assign in conditional to unbreak windows builder. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CustomElementDefinition_h 5 #ifndef CustomElementDefinition_h
6 #define CustomElementDefinition_h 6 #define CustomElementDefinition_h
7 7
8 #include "bindings/core/v8/ScriptValue.h" 8 #include "bindings/core/v8/ScriptValue.h"
9 #include "core/CoreExport.h" 9 #include "core/CoreExport.h"
10 #include "core/dom/custom/CustomElementDescriptor.h" 10 #include "core/dom/custom/CustomElementDescriptor.h"
(...skipping 26 matching lines...) Expand all
37 37
38 using ConstructionStack = HeapVector<Member<Element>, 1>; 38 using ConstructionStack = HeapVector<Member<Element>, 1>;
39 ConstructionStack& constructionStack() 39 ConstructionStack& constructionStack()
40 { 40 {
41 return m_constructionStack; 41 return m_constructionStack;
42 } 42 }
43 43
44 void upgrade(Element*); 44 void upgrade(Element*);
45 45
46 protected: 46 protected:
47 // TODO(dominicc): Make this pure virtual when the script side is 47 virtual bool runConstructor(Element*) = 0;
48 // implemented.
49 virtual bool runConstructor(Element*);
50 48
51 private: 49 private:
52 const CustomElementDescriptor m_descriptor; 50 const CustomElementDescriptor m_descriptor;
53 ConstructionStack m_constructionStack; 51 ConstructionStack m_constructionStack;
54 }; 52 };
55 53
56 } // namespace blink 54 } // namespace blink
57 55
58 #endif // CustomElementDefinition_h 56 #endif // CustomElementDefinition_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698