Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2035593002:
Disable CrOS VEA for Media Recorder (Closed)
|
Created:
4 years, 6 months ago by emircan Modified:
4 years, 6 months ago Reviewers:
mcasas CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable CrOS VEA for Media Recorder
After coming across to certain bugs on different CrOS platforms, we decided to
do manuel tests before enabling HW VEA for CrOS.
BUG=616659
Committed: https://crrev.com/462491b11ddcaf2e4b4378aed9a24c633b200ce2
Cr-Commit-Position: refs/heads/master@{#397550}
Patch Set 1 : #
Total comments: 4
Patch Set 2 : #Messages
Total messages: 16 (10 generated)
Description was changed from ========== dis BUG= ========== to ========== Disable CrOs VEA for Media Recorder BUG=616659 ==========
emircan@chromium.org changed reviewers: + mcasas@chromium.org
PTAL.
Patchset #1 (id:1) has been deleted
Description was changed from ========== Disable CrOs VEA for Media Recorder BUG=616659 ========== to ========== Disable CrOS VEA for Media Recorder BUG=616659 ==========
LGTM % comments below https://codereview.chromium.org/2035593002/diff/20001/content/renderer/media/... File content/renderer/media/video_track_recorder.cc (right): https://codereview.chromium.org/2035593002/diff/20001/content/renderer/media/... content/renderer/media/video_track_recorder.cc:69: // See crbug.com/616659. nit: shift this line two spaces right. https:// before the crbug. https://codereview.chromium.org/2035593002/diff/20001/content/renderer/media/... content/renderer/media/video_track_recorder.cc:72: #endif // defined(OS_CHROMEOS) It might be that some compilers will complain about unreachable code below, and then you'll have to sandwich it onto a #else...
Description was changed from ========== Disable CrOS VEA for Media Recorder BUG=616659 ========== to ========== Disable CrOS VEA for Media Recorder After coming across to certain bugs on different CrOS platforms, we decided to do manuel tests before enabling HW VEA for CrOS. BUG=616659 ==========
Patchset #2 (id:40001) has been deleted
https://codereview.chromium.org/2035593002/diff/20001/content/renderer/media/... File content/renderer/media/video_track_recorder.cc (right): https://codereview.chromium.org/2035593002/diff/20001/content/renderer/media/... content/renderer/media/video_track_recorder.cc:69: // See crbug.com/616659. On 2016/06/02 02:48:51, mcasas wrote: > nit: shift this line two spaces right. > > https:// before the crbug. Done. https://codereview.chromium.org/2035593002/diff/20001/content/renderer/media/... content/renderer/media/video_track_recorder.cc:72: #endif // defined(OS_CHROMEOS) On 2016/06/02 02:48:51, mcasas wrote: > It might be that some compilers will complain about > unreachable code below, and then you'll have to > sandwich it onto a #else... Acknowledged.
The CQ bit was checked by emircan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org Link to the patchset: https://codereview.chromium.org/2035593002/#ps60001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035593002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2035593002/60001
Message was sent while issue was closed.
Description was changed from ========== Disable CrOS VEA for Media Recorder After coming across to certain bugs on different CrOS platforms, we decided to do manuel tests before enabling HW VEA for CrOS. BUG=616659 ========== to ========== Disable CrOS VEA for Media Recorder After coming across to certain bugs on different CrOS platforms, we decided to do manuel tests before enabling HW VEA for CrOS. BUG=616659 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Disable CrOS VEA for Media Recorder After coming across to certain bugs on different CrOS platforms, we decided to do manuel tests before enabling HW VEA for CrOS. BUG=616659 ========== to ========== Disable CrOS VEA for Media Recorder After coming across to certain bugs on different CrOS platforms, we decided to do manuel tests before enabling HW VEA for CrOS. BUG=616659 Committed: https://crrev.com/462491b11ddcaf2e4b4378aed9a24c633b200ce2 Cr-Commit-Position: refs/heads/master@{#397550} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/462491b11ddcaf2e4b4378aed9a24c633b200ce2 Cr-Commit-Position: refs/heads/master@{#397550} |
