Issue 2035583004: Fix a few cases were obj and name were used instead of $obj and $name. remove ProfileEntry class as…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2035583004: Fix a few cases were obj and name were used instead of $obj and $name. remove ProfileEntry class as… (Closed)

Created:
4 years, 6 months ago by Jacob

Modified:
4 years, 6 months ago

Reviewers:
priscillalee

CC:
dev-compiler+reviews_dartlang.org, Leaf

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix a few cases were obj and name were used instead of $obj and $name. remove ProfileEntry class as sadly defining a class in operations.dart appears to have an ordering issue which causes two tests to fail. Committed: https://github.com/dart-lang/dev_compiler/commit/c45d1730ace8495116d21ddf2c20cf8421660a96

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -58 lines)			Patch
	M	lib/runtime/dart_sdk.js	View		7 chunks	+34 lines, -43 lines	0 comments	Download
	M	tool/input_sdk/private/ddc_runtime/operations.dart	View		5 chunks	+7 lines, -15 lines	0 comments	Download

Total messages: 4 (2 generated)

Jacob

4 years, 6 months ago (2016-06-02 20:07:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c45d1730ace8495116d21ddf2c20cf8421660a96 (presubmit successful).