Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2035583003: Revert of Make click targets inside links work. (Closed)

Created:
4 years, 6 months ago by jbroman
Modified:
4 years, 6 months ago
Reviewers:
nektarios, dmazzoni
CC:
aboxhall+watch_chromium.org, aboxhall, blink-reviews, chromium-reviews, dmazzoni+watch_chromium.org, dmazzoni, dtseng+watch_chromium.org, haraken, je_julie, nektar+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make click targets inside links work. (patchset #4 id:60001 of https://codereview.chromium.org/2021953002/ ) Reason for revert: Flakily timing out: https://bugs.chromium.org/p/chromium/issues/detail?id=616768 Original issue's description: > Make click targets inside links work. > > There are pages that attach click handlers to elements that are found inside links, and screen readers might try to click such elements. Our existing doDefaultAction logic wasn't handling this possibility. > For example, there might be a graphic inside a link and the screen reader might invoke the default action on the graphic. > BUG=615904 > R=dmazzoni@chromium.org > > Committed: https://crrev.com/d4cff44e1023869434c07689e29ee4440a3b7a2e > Cr-Commit-Position: refs/heads/master@{#397211} TBR=dmazzoni@chromium.org,nektar@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=615904, 616768 Committed: https://crrev.com/d86069ee9b4f00d97d5658f3fd2a9b3842b15bb9 Cr-Commit-Position: refs/heads/master@{#397416}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -92 lines) Patch
D third_party/WebKit/LayoutTests/accessibility/image-inside-link.html View 1 chunk +0 lines, -87 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
jbroman
Created Revert of Make click targets inside links work.
4 years, 6 months ago (2016-06-02 15:34:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2035583003/1
4 years, 6 months ago (2016-06-02 15:35:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 15:36:25 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 15:39:12 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d86069ee9b4f00d97d5658f3fd2a9b3842b15bb9
Cr-Commit-Position: refs/heads/master@{#397416}

Powered by Google App Engine
This is Rietveld 408576698