Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2035483005: Fix uses of SkImageInfo in BRD to preserve color space info (Closed)

Created:
4 years, 6 months ago by msarett
Modified:
4 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix uses of SkImageInfo in BRD to preserve color space info BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2035483005 Committed: https://skia.googlesource.com/skia/+/577967c155fe3e2ce8251b053da60bd0d8fb32f4

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M src/android/SkBitmapRegionCodec.cpp View 3 chunks +5 lines, -7 lines 2 comments Download

Messages

Total messages: 13 (6 generated)
msarett
4 years, 6 months ago (2016-06-03 14:54:47 UTC) #3
scroggo
lgtm https://codereview.chromium.org/2035483005/diff/1/src/android/SkBitmapRegionCodec.cpp File src/android/SkBitmapRegionCodec.cpp (right): https://codereview.chromium.org/2035483005/diff/1/src/android/SkBitmapRegionCodec.cpp#newcode135 src/android/SkBitmapRegionCodec.cpp:135: return conversion_possible(fCodec->getInfo().makeColorType(colorType), fCodec->getInfo()); I suppose we'll need to ...
4 years, 6 months ago (2016-06-03 15:01:59 UTC) #4
msarett
https://codereview.chromium.org/2035483005/diff/1/src/android/SkBitmapRegionCodec.cpp File src/android/SkBitmapRegionCodec.cpp (right): https://codereview.chromium.org/2035483005/diff/1/src/android/SkBitmapRegionCodec.cpp#newcode135 src/android/SkBitmapRegionCodec.cpp:135: return conversion_possible(fCodec->getInfo().makeColorType(colorType), fCodec->getInfo()); On 2016/06/03 15:01:59, scroggo wrote: > ...
4 years, 6 months ago (2016-06-03 15:08:32 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035483005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2035483005/1
4 years, 6 months ago (2016-06-03 15:08:46 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-03 15:21:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035483005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2035483005/1
4 years, 6 months ago (2016-06-03 15:22:27 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 15:23:44 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/577967c155fe3e2ce8251b053da60bd0d8fb32f4

Powered by Google App Engine
This is Rietveld 408576698