Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2035473003: Avoid runtime type errors in checked mode for ChunkedConverters. (Closed)

Created:
4 years, 6 months ago by floitsch
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Avoid runtime type errors in checked mode for ChunkedConverters. R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/d3579131c80434941855ce9cf1ebaee85767a4aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -15 lines) Patch
M sdk/lib/convert/ascii.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M sdk/lib/convert/base64.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M sdk/lib/convert/converter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/convert/html_escape.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/convert/json.dart View 3 chunks +7 lines, -3 lines 0 comments Download
M sdk/lib/convert/line_splitter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/convert/utf.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M sdk/lib/io/data_transformer.dart View 1 chunk +3 lines, -1 line 0 comments Download
M sdk/lib/io/string_transformer.dart View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
floitsch
4 years, 6 months ago (2016-06-02 11:18:15 UTC) #2
Lasse Reichstein Nielsen
lgtm
4 years, 6 months ago (2016-06-02 11:38:13 UTC) #3
floitsch
4 years, 6 months ago (2016-06-02 11:41:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d3579131c80434941855ce9cf1ebaee85767a4aa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698