Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Issue 203543002: Move Image related tests from web/tests/ to platform/ (Closed)

Created:
6 years, 9 months ago by dshwang
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move Image related tests from web/tests/ to platform/ Move BitmapImageTest.cpp, GIFImageDecoderTest.cpp and JPEGImageDecoderTest.cpp. BUG=353585 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169544

Patch Set 1 #

Patch Set 2 : rebase to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -850 lines) Patch
M Source/platform/blink_platform.gypi View 1 2 chunks +3 lines, -0 lines 0 comments Download
A + Source/platform/graphics/BitmapImageTest.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/image-decoders/jpeg/JPEGImageDecoderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/web/tests/BitmapImageTest.cpp View 1 chunk +0 lines, -161 lines 0 comments Download
D Source/web/tests/GIFImageDecoderTest.cpp View 1 chunk +0 lines, -502 lines 0 comments Download
D Source/web/tests/JPEGImageDecoderTest.cpp View 1 chunk +0 lines, -185 lines 0 comments Download
M Source/web/web.gypi View 1 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dshwang
6 years, 9 months ago (2014-03-18 16:29:25 UTC) #1
jamesr
lgtm
6 years, 9 months ago (2014-03-18 19:20:03 UTC) #2
dshwang
On 2014/03/18 19:20:03, jamesr wrote: > lgtm Thank you for review!
6 years, 9 months ago (2014-03-18 20:53:37 UTC) #3
dshwang
The CQ bit was checked by dongseong.hwang@intel.com
6 years, 9 months ago (2014-03-19 09:03:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/203543002/20001
6 years, 9 months ago (2014-03-19 09:03:36 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 09:31:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-19 09:31:19 UTC) #7
dshwang
The CQ bit was checked by dongseong.hwang@intel.com
6 years, 9 months ago (2014-03-19 11:39:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/203543002/20001
6 years, 9 months ago (2014-03-19 11:39:31 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 12:07:54 UTC) #10
Message was sent while issue was closed.
Change committed as 169544

Powered by Google App Engine
This is Rietveld 408576698