[turbofan] Type feedback for numeric comparisons.

src/compiler/type-hints.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/type-hints.h"
 
 namespace v8 {
 namespace internal {
 namespace compiler {
 
 std::ostream& operator<<(std::ostream& os, BinaryOperationHints::Hint hint) {
   switch (hint) {
     case BinaryOperationHints::kNone:
       return os << "None";
     case BinaryOperationHints::kSignedSmall:
       return os << "SignedSmall";
     case BinaryOperationHints::kSigned32:
       return os << "Signed32";
     case BinaryOperationHints::kNumberOrUndefined:
       return os << "NumberOrUndefined";
     case BinaryOperationHints::kString:
       return os << "String";
     case BinaryOperationHints::kAny:
       return os << "Any";
   }
   UNREACHABLE();
   return os;
 }
 
-
 std::ostream& operator<<(std::ostream& os, BinaryOperationHints hints) {
   return os << hints.left() << "*" << hints.right() << "->" << hints.result();
 }
 
+std::ostream& operator<<(std::ostream& os, CompareOperationHints::Hint hint) {
+  switch (hint) {
+    case CompareOperationHints::kNone:
+      return os << "None";
+    case CompareOperationHints::kSignedSmall:
+      return os << "SignedSmall";
+    case CompareOperationHints::kSigned32:
+      return os << "Signed32";
+    case CompareOperationHints::kNumberOrUndefined:
+      return os << "NumberOrUndefined";
+    case CompareOperationHints::kString:
+      return os << "String";
+    case CompareOperationHints::kAny:
+      return os << "Any";
+  }
+  UNREACHABLE();
+  return os;
+}
+
+std::ostream& operator<<(std::ostream& os, CompareOperationHints hints) {
+  return os << hints.left() << "*" << hints.right() << " (" << hints.combined()
+            << ")";
+}
 
 std::ostream& operator<<(std::ostream& os, ToBooleanHint hint) {
   switch (hint) {
     case ToBooleanHint::kNone:
       return os << "None";
     case ToBooleanHint::kUndefined:
       return os << "Undefined";
     case ToBooleanHint::kBoolean:
       return os << "Boolean";
     case ToBooleanHint::kNull:
@@ skipping 10 matching lines @@
       return os << "HeapNumber";
     case ToBooleanHint::kSimdValue:
       return os << "SimdValue";
     case ToBooleanHint::kAny:
       return os << "Any";
   }
   UNREACHABLE();
   return os;
 }
 
-
 std::ostream& operator<<(std::ostream& os, ToBooleanHints hints) {
   if (hints == ToBooleanHint::kAny) return os << "Any";
   if (hints == ToBooleanHint::kNone) return os << "None";
   bool first = true;
   for (ToBooleanHints::mask_type i = 0; i < sizeof(i) * CHAR_BIT; ++i) {
     ToBooleanHint const hint = static_cast<ToBooleanHint>(1u << i);
     if (hints & hint) {
       if (!first) os << "|";
       first = false;
       os << hint;
     }
   }
   return os;
 }
 
 // static
 bool BinaryOperationHints::Is(Hint h1, Hint h2) {
   if (h1 == h2) return true;
   switch (h1) {
-    case kNone:
+    case BinaryOperationHints::kNone:

[Benedikt Meurer, 2016/06/07 04:11:00]

This change doesn't seem necessary?

[Jarin, 2016/06/09 13:37:32]

Done.

       return true;
-    case kSignedSmall:
-      return h2 == kSigned32 || h2 == kNumberOrUndefined || h2 == kAny;
-    case kSigned32:
-      return h2 == kNumberOrUndefined || h2 == kAny;
-    case kNumberOrUndefined:
-      return h2 == kAny;
-    case kString:
-      return h2 == kAny;
-    case kAny:
+    case BinaryOperationHints::kSignedSmall:
+      return h2 == BinaryOperationHints::kSigned32 ||
+             h2 == BinaryOperationHints::kNumberOrUndefined ||
+             h2 == BinaryOperationHints::kAny;
+    case BinaryOperationHints::kSigned32:
+      return h2 == BinaryOperationHints::kNumberOrUndefined ||
+             h2 == BinaryOperationHints::kAny;
+    case BinaryOperationHints::kNumberOrUndefined:
+      return h2 == BinaryOperationHints::kAny;
+    case BinaryOperationHints::kString:
+      return h2 == BinaryOperationHints::kAny;
+    case BinaryOperationHints::kAny:
       return false;
   }
   UNREACHABLE();
   return false;
 }
 
 // static
 BinaryOperationHints::Hint BinaryOperationHints::Combine(Hint h1, Hint h2) {
   if (Is(h1, h2)) return h2;
   if (Is(h2, h1)) return h1;
-  return kAny;
+  return BinaryOperationHints::kAny;

[Benedikt Meurer, 2016/06/07 04:11:00]

This change doesn't seem necessary?

[Jarin, 2016/06/09 13:37:32]

Done.

 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8