Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: src/compiler/verifier.cc

Issue 2035383003: [turbofan] Type feedback for numeric comparisons. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase, pure ops Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | test/cctest/compiler/test-js-typed-lowering.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 671 matching lines...) Expand 10 before | Expand all | Expand 10 after
682 break; 682 break;
683 case IrOpcode::kNumberLessThan: 683 case IrOpcode::kNumberLessThan:
684 case IrOpcode::kNumberLessThanOrEqual: 684 case IrOpcode::kNumberLessThanOrEqual:
685 // (Number, Number) -> Boolean 685 // (Number, Number) -> Boolean
686 CheckValueInputIs(node, 0, Type::Number()); 686 CheckValueInputIs(node, 0, Type::Number());
687 CheckValueInputIs(node, 1, Type::Number()); 687 CheckValueInputIs(node, 1, Type::Number());
688 CheckUpperIs(node, Type::Boolean()); 688 CheckUpperIs(node, Type::Boolean());
689 break; 689 break;
690 case IrOpcode::kSpeculativeNumberAdd: 690 case IrOpcode::kSpeculativeNumberAdd:
691 case IrOpcode::kSpeculativeNumberSubtract: 691 case IrOpcode::kSpeculativeNumberSubtract:
692 CheckUpperIs(node, Type::Number());
693 break;
694 case IrOpcode::kSpeculativeNumberEqual:
695 case IrOpcode::kSpeculativeNumberLessThan:
696 case IrOpcode::kSpeculativeNumberLessThanOrEqual:
697 CheckUpperIs(node, Type::Boolean());
692 break; 698 break;
693 case IrOpcode::kNumberAdd: 699 case IrOpcode::kNumberAdd:
694 case IrOpcode::kNumberSubtract: 700 case IrOpcode::kNumberSubtract:
695 case IrOpcode::kNumberMultiply: 701 case IrOpcode::kNumberMultiply:
696 case IrOpcode::kNumberDivide: 702 case IrOpcode::kNumberDivide:
697 // (Number, Number) -> Number 703 // (Number, Number) -> Number
698 CheckValueInputIs(node, 0, Type::Number()); 704 CheckValueInputIs(node, 0, Type::Number());
699 CheckValueInputIs(node, 1, Type::Number()); 705 CheckValueInputIs(node, 1, Type::Number());
700 CheckUpperIs(node, Type::Number()); 706 CheckUpperIs(node, Type::Number());
701 break; 707 break;
(...skipping 749 matching lines...) Expand 10 before | Expand all | Expand 10 after
1451 replacement->op()->EffectOutputCount() > 0); 1457 replacement->op()->EffectOutputCount() > 0);
1452 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1458 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1453 replacement->opcode() == IrOpcode::kFrameState); 1459 replacement->opcode() == IrOpcode::kFrameState);
1454 } 1460 }
1455 1461
1456 #endif // DEBUG 1462 #endif // DEBUG
1457 1463
1458 } // namespace compiler 1464 } // namespace compiler
1459 } // namespace internal 1465 } // namespace internal
1460 } // namespace v8 1466 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | test/cctest/compiler/test-js-typed-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698