Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2035343002: [Android] Revert x86 workaround changes for NDK r11c. (Closed)

Created:
4 years, 6 months ago by jbudorick
Modified:
4 years, 6 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/common/android/include/sys/user.h View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jbudorick
This reverts the x86 part of https://codereview.chromium.org/2025923003/, which doesn't work for platforms/android-16.
4 years, 6 months ago (2016-06-06 03:52:53 UTC) #2
Primiano Tucci (use gerrit)
ouch, LGTM. Good try. Only two things are forever: diamonds and typos in droid platform ...
4 years, 6 months ago (2016-06-06 08:48:44 UTC) #3
jbudorick
TBR: fixing x86 build
4 years, 6 months ago (2016-06-06 13:00:55 UTC) #5
Primiano Tucci (use gerrit)
4 years, 6 months ago (2016-06-06 13:35:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7933830cb768faeb4c46a70f89d258492c84108b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698