Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 2035323002: Remove embedder param for SetNotificationSettingForOrigin (Closed)

Created:
4 years, 6 months ago by lshang
Modified:
4 years, 6 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove embedder param for SetNotificationSettingForOrigin Notifications content settings don't consider the embedding origin when updating the content setting values. Remove unused embedder param in SetNotificationSettingForOrigin. Committed: https://crrev.com/20703877cf833973fabdc00e2c6f559f5d635b4c Cr-Commit-Position: refs/heads/master@{#398180}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/NotificationInfo.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferenceBridge.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/preferences/website_preference_bridge.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
lshang
PTAL thanks!
4 years, 6 months ago (2016-06-06 01:31:30 UTC) #3
Bernhard Bauer
LGTM, thanks!
4 years, 6 months ago (2016-06-06 14:59:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035323002/1
4 years, 6 months ago (2016-06-07 00:52:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 00:57:55 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 00:59:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20703877cf833973fabdc00e2c6f559f5d635b4c
Cr-Commit-Position: refs/heads/master@{#398180}

Powered by Google App Engine
This is Rietveld 408576698