Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2035313008: [Cronet] Make StartNetLog and StopNetLog synchronous in Cronet (Closed)

Created:
4 years, 6 months ago by xunjieli
Modified:
4 years, 6 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Make StartNetLog and StopNetLog synchronous in Cronet CronetEngine.StartNetLogToFile and StopNetLog post asynchronous tasks to the network thread. This results truncated logs if executing those tasks is slow on the network thread. Since NetLog is a global and thread-safe, this CL creates and tears down WriteToFileNetLogObserver on the calling Java thread. The access to WriteToFileNetLogObserver is protected by a lock to ensure thread safety. BUG=617632 Committed: https://crrev.com/2a0656e9ea5eac86f6dedbc9ea733c6b95b58d04 Cr-Commit-Position: refs/heads/master@{#398612}

Patch Set 1 #

Patch Set 2 : self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -36 lines) Patch
M components/cronet/android/cronet_url_request_context_adapter.h View 1 3 chunks +6 lines, -7 lines 0 comments Download
M components/cronet/android/cronet_url_request_context_adapter.cc View 3 chunks +12 lines, -29 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
xunjieli
4 years, 6 months ago (2016-06-07 16:48:24 UTC) #2
mmenke
LGTM
4 years, 6 months ago (2016-06-08 15:33:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035313008/20001
4 years, 6 months ago (2016-06-08 17:00:27 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-08 17:46:49 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 17:48:10 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2a0656e9ea5eac86f6dedbc9ea733c6b95b58d04
Cr-Commit-Position: refs/heads/master@{#398612}

Powered by Google App Engine
This is Rietveld 408576698