Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2035313004: Update Windows build output path in .bat files (Closed)

Created:
4 years, 6 months ago by zra
Modified:
4 years, 6 months ago
Reviewers:
Bill Hesse, siva
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M sdk/bin/dart.bat View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dart2js.bat View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartanalyzer.bat View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/bin/dartanalyzer_sdk.bat View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartdevc.bat View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/bin/dartdevc_sdk.bat View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartdoc.bat View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartfmt.bat View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/bin/dartfmt_sdk.bat View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/pub.bat View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zra
4 years, 6 months ago (2016-06-06 15:30:59 UTC) #3
Bill Hesse
lgtm
4 years, 6 months ago (2016-06-06 18:47:08 UTC) #4
siva
lgtm
4 years, 6 months ago (2016-06-06 21:13:02 UTC) #5
Johnni Winther
Committed patchset #1 (id:1) manually as 40108f661daf8ddf5b0910d8646421a4fa71c863 (presubmit successful).
4 years, 6 months ago (2016-06-07 08:43:29 UTC) #7
Johnni Winther
4 years, 6 months ago (2016-06-07 08:44:23 UTC) #8
Message was sent while issue was closed. 
On 2016/06/07 08:43:29, Johnni Winther wrote:
> Committed patchset #1 (id:1) manually as
> 40108f661daf8ddf5b0910d8646421a4fa71c863 (presubmit successful).

Took the liberty of committing this. I tested it locally and it fixes my
problems.

Powered by Google App Engine
This is Rietveld 408576698