[Chromoting] Decouple DesktopView and TouchInputHandler

[Chromoting] Decouple DesktopView and TouchInputHandler

This change decouples DesktopView(Interface) and TouchInputHandler(Interface) by
removing routing functions
DesktopViewInterface.onSoftInputMethodVisibilityChanged and
DesktopViewInterface.setInputStrategy. After this change, TouchInputHandler
takes responsibility to listen to onInputModeChanged and
onSoftInputMethodVisibilityChanged events of Desktop activity directly.

This is part remoting desktop Android client refactor work, a design doc is @
https://goo.gl/MA6zjx.

BUG=615277
Committed: https://crrev.com/96f227fa9b64bb434c0fc0ec6f00aec85b16cb98
Cr-Commit-Position: refs/heads/master@{#398192}

[Hzj_jie, 2016-06-05 21:30:18]

Description was changed from

==========
[Chromoting] Decouple DesktopView and TouchInputHandler

This change decouples DesktopView(Interface) and TouchInputHandler(Interface) by
removing routing functions
DesktopViewInterface.onSoftInputMethodVisibilityChanged and
DesktopViewInterface.setInputStrategy. After this change, TouchInputHandler
takes responsibility to listen to onInputModeChanged and
onSoftInputMethodVisibilityChanged events of Desktop activity directly.

This is part remoting desktop Android client refactor work, a design doc is @
https://goo.gl/MA6zjx.

BUG=615277
==========

to

==========
[Chromoting] Decouple DesktopView and TouchInputHandler

This change decouples DesktopView(Interface) and TouchInputHandler(Interface) by
removing routing functions
DesktopViewInterface.onSoftInputMethodVisibilityChanged and
DesktopViewInterface.setInputStrategy. After this change, TouchInputHandler
takes responsibility to listen to onInputModeChanged and
onSoftInputMethodVisibilityChanged events of Desktop activity directly.

This is part remoting desktop Android client refactor work, a design doc is @
https://goo.gl/MA6zjx.

BUG=615277
==========

[Hzj_jie, 2016-06-05 21:30:19]

zijiehe@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[Lambros, 2016-06-06 22:11:34]

lgtm

https://codereview.chromium.org/2035303002/diff/1/remoting/android/java/src/o...
File remoting/android/java/src/org/chromium/chromoting/Preconditions.java
(right):

https://codereview.chromium.org/2035303002/diff/1/remoting/android/java/src/o...
remoting/android/java/src/org/chromium/chromoting/Preconditions.java:28: *
Checks whether input |ref| is not a null reference, and return its value. Throws
returns its value

https://codereview.chromium.org/2035303002/diff/1/remoting/android/java/src/o...
remoting/android/java/src/org/chromium/chromoting/Preconditions.java:39: *
Checks whether input |ref| is a null reference, and return tis value. Throws
returns its value

https://codereview.chromium.org/2035303002/diff/1/remoting/android/java/src/o...
File remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java
(right):

https://codereview.chromium.org/2035303002/diff/1/remoting/android/java/src/o...
remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java:279:
final Desktop.InputMode inputMode = parameter.inputMode;
I think this would be more readable if you pull this block of code out
to a static method, maybe
onInputModeChanged() or handleInputModeChanged().

https://codereview.chromium.org/2035303002/diff/1/remoting/android/java/src/o...
remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java:319:
synchronized (mRenderData) {
And this.

[Hzj_jie, 2016-06-07 01:26:13]

https://codereview.chromium.org/2035303002/diff/1/remoting/android/java/src/o...
File remoting/android/java/src/org/chromium/chromoting/Preconditions.java
(right):

https://codereview.chromium.org/2035303002/diff/1/remoting/android/java/src/o...
remoting/android/java/src/org/chromium/chromoting/Preconditions.java:28: *
Checks whether input |ref| is not a null reference, and return its value. Throws
On 2016/06/06 22:11:34, Lambros wrote:
> returns its value

Done.

https://codereview.chromium.org/2035303002/diff/1/remoting/android/java/src/o...
remoting/android/java/src/org/chromium/chromoting/Preconditions.java:39: *
Checks whether input |ref| is a null reference, and return tis value. Throws
On 2016/06/06 22:11:34, Lambros wrote:
> returns its value

Done.

https://codereview.chromium.org/2035303002/diff/1/remoting/android/java/src/o...
File remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java
(right):

https://codereview.chromium.org/2035303002/diff/1/remoting/android/java/src/o...
remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java:279:
final Desktop.InputMode inputMode = parameter.inputMode;
On 2016/06/06 22:11:34, Lambros wrote:
> I think this would be more readable if you pull this block of code out
> to a static method, maybe
> onInputModeChanged() or handleInputModeChanged().

Done.

https://codereview.chromium.org/2035303002/diff/1/remoting/android/java/src/o...
remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java:319:
synchronized (mRenderData) {
On 2016/06/06 22:11:34, Lambros wrote:
> And this.

Done.

[Hzj_jie, 2016-06-07 01:26:56]

The CQ bit was checked by zijiehe@chromium.org

[Hzj_jie, 2016-06-07 01:26:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
lambroslambrou@chromium.org
Link to the patchset: https://codereview.chromium.org/2035303002/#ps40001
(title: "Sync latest changes")

[commit-bot: I haz the power, 2016-06-07 01:27:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035303002/40001

[commit-bot: I haz the power, 2016-06-07 01:34:00]

Description was changed from

==========
[Chromoting] Decouple DesktopView and TouchInputHandler

This change decouples DesktopView(Interface) and TouchInputHandler(Interface) by
removing routing functions
DesktopViewInterface.onSoftInputMethodVisibilityChanged and
DesktopViewInterface.setInputStrategy. After this change, TouchInputHandler
takes responsibility to listen to onInputModeChanged and
onSoftInputMethodVisibilityChanged events of Desktop activity directly.

This is part remoting desktop Android client refactor work, a design doc is @
https://goo.gl/MA6zjx.

BUG=615277
==========

to

==========
[Chromoting] Decouple DesktopView and TouchInputHandler

This change decouples DesktopView(Interface) and TouchInputHandler(Interface) by
removing routing functions
DesktopViewInterface.onSoftInputMethodVisibilityChanged and
DesktopViewInterface.setInputStrategy. After this change, TouchInputHandler
takes responsibility to listen to onInputModeChanged and
onSoftInputMethodVisibilityChanged events of Desktop activity directly.

This is part remoting desktop Android client refactor work, a design doc is @
https://goo.gl/MA6zjx.

BUG=615277
==========

[commit-bot: I haz the power, 2016-06-07 01:34:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-07 01:37:14]

Description was changed from

==========
[Chromoting] Decouple DesktopView and TouchInputHandler

This change decouples DesktopView(Interface) and TouchInputHandler(Interface) by
removing routing functions
DesktopViewInterface.onSoftInputMethodVisibilityChanged and
DesktopViewInterface.setInputStrategy. After this change, TouchInputHandler
takes responsibility to listen to onInputModeChanged and
onSoftInputMethodVisibilityChanged events of Desktop activity directly.

This is part remoting desktop Android client refactor work, a design doc is @
https://goo.gl/MA6zjx.

BUG=615277
==========

to

==========
[Chromoting] Decouple DesktopView and TouchInputHandler

This change decouples DesktopView(Interface) and TouchInputHandler(Interface) by
removing routing functions
DesktopViewInterface.onSoftInputMethodVisibilityChanged and
DesktopViewInterface.setInputStrategy. After this change, TouchInputHandler
takes responsibility to listen to onInputModeChanged and
onSoftInputMethodVisibilityChanged events of Desktop activity directly.

This is part remoting desktop Android client refactor work, a design doc is @
https://goo.gl/MA6zjx.

BUG=615277

Committed: https://crrev.com/96f227fa9b64bb434c0fc0ec6f00aec85b16cb98
Cr-Commit-Position: refs/heads/master@{#398192}
==========

[commit-bot: I haz the power, 2016-06-07 01:37:15]

Patchset 3 (id:??) landed as
https://crrev.com/96f227fa9b64bb434c0fc0ec6f00aec85b16cb98
Cr-Commit-Position: refs/heads/master@{#398192}