Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc

Issue 2035293002: Remove URLRequest::GetResponseCookies and URLRequestJob::GetResponseCookies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc
diff --git a/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc b/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc
index df07790d92ef4a61c6f401b5ec98a39c8bb873a1..ead226c2af527cd9bc9c755759681241eafbe687 100644
--- a/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc
+++ b/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc
@@ -8,6 +8,7 @@
#include "base/bind_helpers.h"
#include "base/callback.h"
#include "base/macros.h"
+#include "base/memory/ref_counted.h"
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "base/sequenced_task_runner.h"
@@ -44,6 +45,7 @@
#include "google_apis/gaia/gaia_auth_consumer.h"
#include "google_apis/gaia/gaia_constants.h"
#include "google_apis/gaia/gaia_urls.h"
+#include "net/http/http_response_headers.h"
#include "net/url_request/test_url_fetcher_factory.h"
#include "net/url_request/url_fetcher_delegate.h"
#include "net/url_request/url_request_context_getter.h"
@@ -62,7 +64,7 @@ using testing::_;
namespace policy {
-const char kOAuthCodeCookie[] = "oauth_code=1234; Secure; HttpOnly";
+const char kOAuthCodeCookie[] = "Set-Cookie: oauth_code=1234; Secure; HttpOnly";
mmenke 2016/06/08 14:46:44 Maybe rename this kSetOAuthCodeCookie?
martijnc 2016/06/08 16:08:10 Done.
const char kOAuth2TokenPairData[] =
"{"
@@ -240,10 +242,11 @@ class UserCloudPolicyManagerChromeOSTest : public testing::Test {
fetcher = PrepareOAuthFetcher(gaia_urls->client_login_to_oauth2_url());
if (!fetcher)
return NULL;
- net::ResponseCookies cookies;
- cookies.push_back(kOAuthCodeCookie);
- fetcher->set_cookies(cookies);
+ scoped_refptr<net::HttpResponseHeaders> reponse_headers =
+ new net::HttpResponseHeaders("");
+ reponse_headers->AddHeader(kOAuthCodeCookie);
+ fetcher->set_response_headers(reponse_headers);
fetcher->delegate()->OnURLFetchComplete(fetcher);
// Issue the refresh token.

Powered by Google App Engine
This is Rietveld 408576698