net/url_request/url_fetcher_impl_unittest.cc - Issue 2035293002: Remove URLRequest::GetResponseCookies and URLRequestJob::GetResponseCookies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_fetcher_impl_unittest.cc

Issue 2035293002: Remove URLRequest::GetResponseCookies and URLRequestJob::GetResponseCookies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments rogerta Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/url_request/url_fetcher_impl_unittest.cc

diff --git a/net/url_request/url_fetcher_impl_unittest.cc b/net/url_request/url_fetcher_impl_unittest.cc

index efb17a4a89beb64d74f3731f7cc46ee690dafa78..853ea7169c33ca50d8b3eba5163c82403f16ab03 100644

--- a/net/url_request/url_fetcher_impl_unittest.cc

+++ b/net/url_request/url_fetcher_impl_unittest.cc

@@ -1521,7 +1521,7 @@ TEST_F(URLFetcherBadHTTPSTest, BadHTTPS) {

delegate.fetcher()->GetStatus().status());

EXPECT_EQ(ERR_ABORTED, delegate.fetcher()->GetStatus().error());

EXPECT_EQ(-1, delegate.fetcher()->GetResponseCode());

- EXPECT_TRUE(delegate.fetcher()->GetCookies().empty());

+ EXPECT_FALSE(delegate.fetcher()->GetResponseHeaders());

std::string data;

EXPECT_TRUE(delegate.fetcher()->GetResponseAsString(&data));

EXPECT_TRUE(data.empty());

« no previous file with comments | « net/url_request/url_fetcher_impl.cc ('k') | net/url_request/url_request.h » ('j') | no next file with comments »