chrome/browser/safe_browsing/client_side_detection_service.cc - Issue 2035293002: Remove URLRequest::GetResponseCookies and URLRequestJob::GetResponseCookies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service.cc

Issue 2035293002: Remove URLRequest::GetResponseCookies and URLRequestJob::GetResponseCookies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments rogerta Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/client_side_detection_service.h ('k') | chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_service.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_service.cc b/chrome/browser/safe_browsing/client_side_detection_service.cc

index 937b120ddad59eb2373cfc2a48a364f177610105..8360aad560751e57e001ad2f410c7b97396dd923 100644

--- a/chrome/browser/safe_browsing/client_side_detection_service.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_service.cc

@@ -206,14 +206,12 @@ void ClientSideDetectionService::OnURLFetchComplete(

source->GetResponseAsString(&data);

if (client_phishing_reports_.find(source) != client_phishing_reports_.end()) {

- HandlePhishingVerdict(

- source, source->GetURL(), source->GetStatus(),

- source->GetResponseCode(), source->GetCookies(), data);

+ HandlePhishingVerdict(source, source->GetURL(), source->GetStatus(),

+ source->GetResponseCode(), data);

} else if (client_malware_reports_.find(source) !=

client_malware_reports_.end()) {

- HandleMalwareVerdict(

- source, source->GetURL(), source->GetStatus(),

- source->GetResponseCode(), source->GetCookies(), data);

+ HandleMalwareVerdict(source, source->GetURL(), source->GetStatus(),

+ source->GetResponseCode(), data);

} else {

NOTREACHED();

}

@@ -370,7 +368,6 @@ void ClientSideDetectionService::HandlePhishingVerdict(

const GURL& url,

const net::URLRequestStatus& status,

int response_code,

- const net::ResponseCookies& cookies,

const std::string& data) {

ClientPhishingResponse response;

std::unique_ptr<ClientReportInfo> info(client_phishing_reports_[source]);

@@ -397,7 +394,6 @@ void ClientSideDetectionService::HandleMalwareVerdict(

const GURL& url,

const net::URLRequestStatus& status,

int response_code,

- const net::ResponseCookies& cookies,

const std::string& data) {

if (status.is_success()) {

UMA_HISTOGRAM_SPARSE_SLOWLY(