Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Side by Side Diff: net/url_request/url_request_job.h

Issue 2035293002: Remove URLRequest::GetResponseCookies and URLRequestJob::GetResponseCookies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments rogerta Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/url_request/url_request_http_job.cc ('k') | net/url_request/url_request_job.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_URL_REQUEST_URL_REQUEST_JOB_H_ 5 #ifndef NET_URL_REQUEST_URL_REQUEST_JOB_H_
6 #define NET_URL_REQUEST_URL_REQUEST_JOB_H_ 6 #define NET_URL_REQUEST_URL_REQUEST_JOB_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 // This returns the times when events actually occurred, rather than the time 132 // This returns the times when events actually occurred, rather than the time
133 // each event blocked the request. See FixupLoadTimingInfo in url_request.h 133 // each event blocked the request. See FixupLoadTimingInfo in url_request.h
134 // for more information on the difference. 134 // for more information on the difference.
135 virtual void GetLoadTimingInfo(LoadTimingInfo* load_timing_info) const; 135 virtual void GetLoadTimingInfo(LoadTimingInfo* load_timing_info) const;
136 136
137 // Gets the remote endpoint that the network stack is currently fetching the 137 // Gets the remote endpoint that the network stack is currently fetching the
138 // URL from. Returns true and fills in |endpoint| if it is available; returns 138 // URL from. Returns true and fills in |endpoint| if it is available; returns
139 // false and leaves |endpoint| unchanged if it is unavailable. 139 // false and leaves |endpoint| unchanged if it is unavailable.
140 virtual bool GetRemoteEndpoint(IPEndPoint* endpoint) const; 140 virtual bool GetRemoteEndpoint(IPEndPoint* endpoint) const;
141 141
142 // Returns the cookie values included in the response, if applicable.
143 // Returns true if applicable.
144 // NOTE: This removes the cookies from the job, so it will only return
145 // useful results once per job.
146 virtual bool GetResponseCookies(std::vector<std::string>* cookies);
147
148 // Populates the network error details of the most recent origin that the 142 // Populates the network error details of the most recent origin that the
149 // network stack makes the request to. 143 // network stack makes the request to.
150 virtual void PopulateNetErrorDetails(NetErrorDetails* details) const; 144 virtual void PopulateNetErrorDetails(NetErrorDetails* details) const;
151 145
152 // Called to setup a stream filter for this request. An example of filter is 146 // Called to setup a stream filter for this request. An example of filter is
153 // content encoding/decoding. 147 // content encoding/decoding.
154 // Subclasses should return the appropriate Filter, or NULL for no Filter. 148 // Subclasses should return the appropriate Filter, or NULL for no Filter.
155 // This class takes ownership of the returned Filter. 149 // This class takes ownership of the returned Filter.
156 // 150 //
157 // The default implementation returns NULL. 151 // The default implementation returns NULL.
(...skipping 314 matching lines...) Expand 10 before | Expand all | Expand 10 after
472 int64_t last_notified_total_sent_bytes_; 466 int64_t last_notified_total_sent_bytes_;
473 467
474 base::WeakPtrFactory<URLRequestJob> weak_factory_; 468 base::WeakPtrFactory<URLRequestJob> weak_factory_;
475 469
476 DISALLOW_COPY_AND_ASSIGN(URLRequestJob); 470 DISALLOW_COPY_AND_ASSIGN(URLRequestJob);
477 }; 471 };
478 472
479 } // namespace net 473 } // namespace net
480 474
481 #endif // NET_URL_REQUEST_URL_REQUEST_JOB_H_ 475 #endif // NET_URL_REQUEST_URL_REQUEST_JOB_H_
OLDNEW
« no previous file with comments | « net/url_request/url_request_http_job.cc ('k') | net/url_request/url_request_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698