Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: net/url_request/url_request_job.cc

Issue 2035293002: Remove URLRequest::GetResponseCookies and URLRequestJob::GetResponseCookies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments rogerta Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/url_request/url_request_job.h ('k') | sync/internal_api/http_bridge_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_job.h" 5 #include "net/url_request/url_request_job.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 } 184 }
185 185
186 void URLRequestJob::GetLoadTimingInfo(LoadTimingInfo* load_timing_info) const { 186 void URLRequestJob::GetLoadTimingInfo(LoadTimingInfo* load_timing_info) const {
187 // Only certain request types return more than just request start times. 187 // Only certain request types return more than just request start times.
188 } 188 }
189 189
190 bool URLRequestJob::GetRemoteEndpoint(IPEndPoint* endpoint) const { 190 bool URLRequestJob::GetRemoteEndpoint(IPEndPoint* endpoint) const {
191 return false; 191 return false;
192 } 192 }
193 193
194 bool URLRequestJob::GetResponseCookies(std::vector<std::string>* cookies) {
195 return false;
196 }
197
198 void URLRequestJob::PopulateNetErrorDetails(NetErrorDetails* details) const { 194 void URLRequestJob::PopulateNetErrorDetails(NetErrorDetails* details) const {
199 return; 195 return;
200 } 196 }
201 197
202 std::unique_ptr<Filter> URLRequestJob::SetupFilter() const { 198 std::unique_ptr<Filter> URLRequestJob::SetupFilter() const {
203 return nullptr; 199 return nullptr;
204 } 200 }
205 201
206 bool URLRequestJob::IsRedirectResponse(GURL* location, 202 bool URLRequestJob::IsRedirectResponse(GURL* location,
207 int* http_status_code) { 203 int* http_status_code) {
(...skipping 774 matching lines...) Expand 10 before | Expand all | Expand 10 after
982 int64_t total_sent_bytes = GetTotalSentBytes(); 978 int64_t total_sent_bytes = GetTotalSentBytes();
983 DCHECK_GE(total_sent_bytes, last_notified_total_sent_bytes_); 979 DCHECK_GE(total_sent_bytes, last_notified_total_sent_bytes_);
984 if (total_sent_bytes > last_notified_total_sent_bytes_) { 980 if (total_sent_bytes > last_notified_total_sent_bytes_) {
985 network_delegate_->NotifyNetworkBytesSent( 981 network_delegate_->NotifyNetworkBytesSent(
986 request_, total_sent_bytes - last_notified_total_sent_bytes_); 982 request_, total_sent_bytes - last_notified_total_sent_bytes_);
987 } 983 }
988 last_notified_total_sent_bytes_ = total_sent_bytes; 984 last_notified_total_sent_bytes_ = total_sent_bytes;
989 } 985 }
990 986
991 } // namespace net 987 } // namespace net
OLDNEW
« no previous file with comments | « net/url_request/url_request_job.h ('k') | sync/internal_api/http_bridge_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698