Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: net/url_request/url_request_http_job.cc

Issue 2035293002: Remove URLRequest::GetResponseCookies and URLRequestJob::GetResponseCookies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments rogerta Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/url_request/url_request_http_job.h ('k') | net/url_request/url_request_job.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_http_job.h" 5 #include "net/url_request/url_request_http_job.h"
6 6
7 #include "base/base_switches.h" 7 #include "base/base_switches.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/bind_helpers.h" 9 #include "base/bind_helpers.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 1186 matching lines...) Expand 10 before | Expand all | Expand 10 after
1197 load_timing_info->receive_headers_end = receive_headers_end_; 1197 load_timing_info->receive_headers_end = receive_headers_end_;
1198 } 1198 }
1199 1199
1200 bool URLRequestHttpJob::GetRemoteEndpoint(IPEndPoint* endpoint) const { 1200 bool URLRequestHttpJob::GetRemoteEndpoint(IPEndPoint* endpoint) const {
1201 if (!transaction_) 1201 if (!transaction_)
1202 return false; 1202 return false;
1203 1203
1204 return transaction_->GetRemoteEndpoint(endpoint); 1204 return transaction_->GetRemoteEndpoint(endpoint);
1205 } 1205 }
1206 1206
1207 bool URLRequestHttpJob::GetResponseCookies(std::vector<std::string>* cookies) {
1208 DCHECK(transaction_.get());
1209
1210 if (!response_info_)
1211 return false;
1212
1213 cookies->clear();
1214 FetchResponseCookies(cookies);
1215 return true;
1216 }
1217
1218 int URLRequestHttpJob::GetResponseCode() const { 1207 int URLRequestHttpJob::GetResponseCode() const {
1219 DCHECK(transaction_.get()); 1208 DCHECK(transaction_.get());
1220 1209
1221 if (!response_info_) 1210 if (!response_info_)
1222 return -1; 1211 return -1;
1223 1212
1224 return GetResponseHeaders()->response_code(); 1213 return GetResponseHeaders()->response_code();
1225 } 1214 }
1226 1215
1227 void URLRequestHttpJob::PopulateNetErrorDetails( 1216 void URLRequestHttpJob::PopulateNetErrorDetails(
(...skipping 450 matching lines...) Expand 10 before | Expand all | Expand 10 after
1678 // Notify NetworkQualityEstimator. 1667 // Notify NetworkQualityEstimator.
1679 if (request()) { 1668 if (request()) {
1680 NetworkQualityEstimator* network_quality_estimator = 1669 NetworkQualityEstimator* network_quality_estimator =
1681 request()->context()->network_quality_estimator(); 1670 request()->context()->network_quality_estimator();
1682 if (network_quality_estimator) 1671 if (network_quality_estimator)
1683 network_quality_estimator->NotifyURLRequestDestroyed(*request()); 1672 network_quality_estimator->NotifyURLRequestDestroyed(*request());
1684 } 1673 }
1685 } 1674 }
1686 1675
1687 } // namespace net 1676 } // namespace net
OLDNEW
« no previous file with comments | « net/url_request/url_request_http_job.h ('k') | net/url_request/url_request_job.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698