Remove URLRequest::GetResponseCookies and URLRequestJob::GetResponseCookies.

google_apis/gaia/gaia_auth_fetcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "google_apis/gaia/gaia_auth_fetcher.h"
 
 #include <string>
 #include <utility>
 #include <vector>
 
@@ skipping 54 matching lines @@
   }
 
   // Refresh token may not be required.
   if (refresh_token) {
     if (!dict->GetStringWithoutPathExpansion("refresh_token", refresh_token))
       return false;
   }
   return true;
 }
 
+void GetCookiesFromResponse(net::HttpResponseHeaders* headers,

[Roger Tawa OOO till Jul 10th, 2016/06/14 15:57:40]

This should be a const ptr.

[martijnc, 2016/06/14 22:18:08]

Done.

+                            net::ResponseCookies* cookies) {
+  if (!headers)
+    return;
+
+  std::string value;
+  size_t iter = 0;
+  while (headers->EnumerateHeader(&iter, "Set-Cookie", &value)) {
+    if (!value.empty())
+      cookies->push_back(value);
+  }
+}
+
 const char kListIdpServiceRequested[] = "list_idp";
 const char kGetTokenResponseRequested[] = "get_token";
 
 }  // namespace
 
 // static
 const char GaiaAuthFetcher::kIssueAuthTokenFormat[] =
     "SID=%s&"
     "LSID=%s&"
     "service=%s&"
@@ skipping 852 matching lines @@
 // the OnURLFetchComplete callback has run.
 #ifndef NDEBUG
   std::string headers;
   if (source->GetResponseHeaders())
     source->GetResponseHeaders()->GetNormalizedHeaders(&headers);
   DVLOG(2) << "Response " << url.spec() << ", code = " << response_code << "\n"
            << headers << "\n";
   DVLOG(2) << "data: " << data << "\n";
 #endif
 
-  DispatchFetchedRequest(url, data, source->GetCookies(), status,
-                         response_code);
+  net::ResponseCookies cookies;
+  GetCookiesFromResponse(source->GetResponseHeaders(), &cookies);
+  DispatchFetchedRequest(url, data, cookies, status, response_code);
 }
 
 void GaiaAuthFetcher::DispatchFetchedRequest(
     const GURL& url,
     const std::string& data,
     const net::ResponseCookies& cookies,
     const net::URLRequestStatus& status,
     int response_code) {
   if (url == issue_auth_token_gurl_) {
     OnIssueAuthTokenFetched(data, status, response_code);
@@ skipping 38 matching lines @@
   return alleged_error.find(kSecondFactor) !=
       std::string::npos;
 }
 
 // static
 bool GaiaAuthFetcher::IsWebLoginRequiredSuccess(
     const std::string& alleged_error) {
   return alleged_error.find(kWebLoginRequired) !=
       std::string::npos;
 }