Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 203523011: Introduce a lazy-compile stub for functions. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: rebased Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_ia32.cc
===================================================================
--- runtime/vm/flow_graph_compiler_ia32.cc (revision 34642)
+++ runtime/vm/flow_graph_compiler_ia32.cc (working copy)
@@ -1330,26 +1330,11 @@
// be invoked as a normal Dart function.
__ movl(EAX, FieldAddress(EDI, ECX, TIMES_4, base + kWordSize));
__ movl(EBX, FieldAddress(EAX, Function::code_offset()));
- if (FLAG_collect_code) {
- // If we are collecting code, the code object may be null.
- Label is_compiled;
- const Immediate& raw_null =
- Immediate(reinterpret_cast<intptr_t>(Object::null()));
- __ cmpl(EBX, raw_null);
- __ j(NOT_EQUAL, &is_compiled, Assembler::kNearJump);
- __ call(&StubCode::CompileFunctionRuntimeCallLabel());
- AddCurrentDescriptor(PcDescriptors::kRuntimeCall,
- Isolate::kNoDeoptId,
- token_pos);
- RecordSafepoint(locs);
- __ movl(EBX, FieldAddress(EAX, Function::code_offset()));
- __ Bind(&is_compiled);
- }
- __ movl(EAX, FieldAddress(EBX, Code::instructions_offset()));
+ __ movl(EBX, FieldAddress(EBX, Code::instructions_offset()));
__ LoadObject(ECX, ic_data);
__ LoadObject(EDX, arguments_descriptor);
- __ addl(EAX, Immediate(Instructions::HeaderSize() - kHeapObjectTag));
- __ call(EAX);
+ __ addl(EBX, Immediate(Instructions::HeaderSize() - kHeapObjectTag));
+ __ call(EBX);
AddCurrentDescriptor(PcDescriptors::kOther, Isolate::kNoDeoptId, token_pos);
RecordSafepoint(locs);
AddDeoptIndexAtCall(Isolate::ToDeoptAfter(deopt_id), token_pos);
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698