Introduce a lazy-compile stub for functions.

runtime/vm/raw_object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/raw_object.h"
 
 #include "vm/class_table.h"
 #include "vm/dart.h"
 #include "vm/freelist.h"
 #include "vm/isolate.h"
@@ skipping 119 matching lines @@
       case kTypeArgumentsCid: {
         const RawTypeArguments* raw_array =
             reinterpret_cast<const RawTypeArguments*>(this);
         intptr_t array_length = Smi::Value(raw_array->ptr()->length_);
         instance_size = TypeArguments::InstanceSize(array_length);
         break;
       }
       case kPcDescriptorsCid: {
         const RawPcDescriptors* raw_descriptors =
             reinterpret_cast<const RawPcDescriptors*>(this);
-        intptr_t num_descriptors = Smi::Value(raw_descriptors->ptr()->length_);
+        intptr_t num_descriptors = raw_descriptors->ptr()->length_;
         instance_size = PcDescriptors::InstanceSize(num_descriptors);
         break;
       }
       case kStackmapCid: {
         const RawStackmap* map = reinterpret_cast<const RawStackmap*>(this);
         intptr_t length = map->ptr()->length_;
         instance_size = Stackmap::InstanceSize(length);
         break;
       }
       case kLocalVarDescriptorsCid: {
@@ skipping 215 matching lines @@
   // be able to reuse the handle based code and avoid having to add
   // helper functions to the raw object interface.
   Function fn;
   fn = raw_fun;
 
   Code code;
   code = fn.CurrentCode();
 
   if (!code.IsNull() &&  // The function may not have code.
       !code.is_optimized() &&
       (fn.CurrentCode() == fn.unoptimized_code()) &&

[zra, 2014/03/21 14:44:31]

I think you also need to modify this logic, otherwise closures will never be
collected.

[Florian Schneider, 2014/03/21 15:13:58]

Yes, thanks. This also means that collection of closures is untested.

       !code.HasBreakpoint() &&
       (fn.usage_counter() >= 0)) {
     fn.set_usage_counter(fn.usage_counter() / 2);
     if (FLAG_always_drop_code || (fn.usage_counter() == 0)) {
       return true;
     }
   }
   return false;
 }
 
@@ skipping 101 matching lines @@
     if ((pc >= start_pc) && (pc < end_pc)) {
       return true;
     }
   }
   return false;
 }
 
 
 intptr_t RawPcDescriptors::VisitPcDescriptorsPointers(
     RawPcDescriptors* raw_obj, ObjectPointerVisitor* visitor) {
-  RawPcDescriptors* obj = raw_obj->ptr();
-  intptr_t length = Smi::Value(obj->length_);
-  visitor->VisitPointer(reinterpret_cast<RawObject**>(&obj->length_));
-  return PcDescriptors::InstanceSize(length);
+  return PcDescriptors::InstanceSize(raw_obj->ptr()->length_);
 }
 
 
 intptr_t RawStackmap::VisitStackmapPointers(RawStackmap* raw_obj,
                                             ObjectPointerVisitor* visitor) {
-  RawStackmap* obj = raw_obj->ptr();
-  intptr_t length = obj->length_;
-  visitor->VisitPointer(reinterpret_cast<RawObject**>(&obj->code_));
-  return Stackmap::InstanceSize(length);
+  return Stackmap::InstanceSize(raw_obj->ptr()->length_);
 }
 
 
 intptr_t RawLocalVarDescriptors::VisitLocalVarDescriptorsPointers(
     RawLocalVarDescriptors* raw_obj, ObjectPointerVisitor* visitor) {
   RawLocalVarDescriptors* obj = raw_obj->ptr();
   intptr_t len = obj->length_;
   visitor->VisitPointer(reinterpret_cast<RawObject**>(&obj->names_));
   return LocalVarDescriptors::InstanceSize(len);
 }
@@ skipping 314 matching lines @@
 
 intptr_t RawMirrorReference::VisitMirrorReferencePointers(
     RawMirrorReference* raw_obj, ObjectPointerVisitor* visitor) {
   // Make sure that we got here with the tagged pointer as this.
   ASSERT(raw_obj->IsHeapObject());
   visitor->VisitPointers(raw_obj->from(), raw_obj->to());
   return MirrorReference::InstanceSize();
 }
 
 }  // namespace dart