Reland "Add plumbing for font-stretch"

Reland "Add plumbing for font-stretch"

Implement support for parsing and querying the font-stretch CSS
property, for extracting the font-stretch from the short-hand font
property, and for querying the font-stretch through getComputedStyle.

Note that this patch does _not_ implement the font-stretch
functionality itself, it merely adds the required plumbing.

Request to implement thread:
  https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/N24I2zJemvI

Entry in Chromium Dashboard:
  http://www.chromestatus.com/features/4598830058176512

Originally landed as r169264 and rolled out as r169273 due to
linux_blink_dbg test crashes.

R=dglazkov@chromium.org
BUG=331119
TEST=fast/css3-text/font-stretch.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178893

[dglazkov, 2014-03-20 22:42:27]

lgtm

[eae, 2014-03-20 22:43:06]

On 2014/03/20 22:42:27, dglazkov wrote:
> lgtm

I still need to figure out why it hits those inherit ASSERTS

[dglazkov, 2014-03-20 22:43:37]

On 2014/03/20 22:43:06, eae wrote:
> On 2014/03/20 22:42:27, dglazkov wrote:
> > lgtm
> 
> I still need to figure out why it hits those inherit ASSERTS

LOL. Let me smell around and see what I can think of.

[esprehn, 2014-05-06 02:47:48]

Which ASSERTs do you hit?

[eae, 2014-05-06 02:52:36]

assert
in StyleResolver.cpp on line 1191:

template <StyleResolver::StyleApplicationPass pass>
void StyleResolver::applyProperties(StyleResolverState& state, const
StylePropertySet* properties, StyleRule* rule, bool isImportant, bool
inheritedOnly, PropertyWhitelistType propertyWhitelistType)
{
    state.setCurrentRule(rule);

    unsigned propertyCount = properties->propertyCount();
    for (unsigned i = 0; i < propertyCount; ++i) {
        StylePropertySet::PropertyReference current = properties->propertyAt(i);
        if (isImportant != current.isImportant())
            continue;
        if (inheritedOnly && !current.isInherited()) {
            // If the property value is explicitly inherited, we need
to apply further non-inherited properties
            // as they might override the value inherited here. For
this reason we don't allow declarations with
            // explicitly inherited properties to be cached.
            ASSERT(!current.value()->isInheritedValue());
            continue;
        }

This only seems to happen for a bunch of shadow dom pseudoclass test
cases, specifically:
  fast/dom/shadow/pseudoclass-update-checked-option.html [ Crash ]
  fast/dom/shadow/pseudoclass-update-disabled-option.html [ Crash ]
  fast/dom/shadow/pseudoclass-update-enabled-option.html [ Crash ]

[eae, 2014-05-06 19:52:51]

esprehn: See
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_dbg/...
for an example.

[eae, 2014-07-25 03:07:49]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2014-07-25 03:08:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eae@chromium.org/203523002/80001

[commit-bot: I haz the power, 2014-07-25 03:13:36]

Change committed as 178893