Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 203523002: Reland "Add plumbing for font-stretch" (Closed)

Created:
6 years, 9 months ago by eae
Modified:
6 years, 5 months ago
Reviewers:
dglazkov
CC:
blink-reviews, shans, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, rjwright, Steve Block, dino_apple.com, rune+blink, caseq+blink_chromium.org, aandrey+blink_chromium.org, alancutter (OOO until 2018), pfeldman+blink_chromium.org, dsinclair, yurys+blink_chromium.org, dstockwell, Timothy Loh, jchaffraix+rendering, devtools-reviews_chromium.org, bemjb+rendering_chromium.org, pdr., rwlbuis, Eric Willigers, loislo+blink_chromium.org, zoltan1, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, alph+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, Mike Lawther (Google), ed+blinkwatch_opera.com
Visibility:
Public.

Description

Reland "Add plumbing for font-stretch" Implement support for parsing and querying the font-stretch CSS property, for extracting the font-stretch from the short-hand font property, and for querying the font-stretch through getComputedStyle. Note that this patch does _not_ implement the font-stretch functionality itself, it merely adds the required plumbing. Request to implement thread: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/N24I2zJemvI Entry in Chromium Dashboard: http://www.chromestatus.com/features/4598830058176512 Originally landed as r169264 and rolled out as r169273 due to linux_blink_dbg test crashes. R=dglazkov@chromium.org BUG=331119 TEST=fast/css3-text/font-stretch.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178893

Patch Set 1 #

Patch Set 2 : Rebase w/HEAD #

Patch Set 3 : w/fix for ASSERT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+411 lines, -143 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/css/first-letter-property-whitelist.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/font-shorthand-expected.txt View 9 chunks +9 lines, -0 lines 0 comments Download
M LayoutTests/fast/css/font-shorthand-from-longhands.html View 2 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/fast/css/font-shorthand-from-longhands-expected.txt View 1 chunk +9 lines, -9 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-font-expected.txt View 1 chunk +56 lines, -56 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/script-tests/computed-style-font.js View 1 chunk +56 lines, -56 lines 0 comments Download
M LayoutTests/fast/inspector-support/style-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/inspector/console/console-format-style-whitelist-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 2 chunks +12 lines, -0 lines 0 comments Download
M Source/core/animation/css/CSSPropertyEquality.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 5 chunks +30 lines, -1 line 0 comments Download
M Source/core/css/CSSFontValue.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSFontValue.cpp View 1 3 chunks +7 lines, -1 line 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 1 1 chunk +70 lines, -0 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 2 chunks +1 line, -1 line 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 2 2 chunks +1 line, -1 line 0 comments Download
M Source/core/css/CSSPropertyNames.in View 1 2 chunks +1 line, -1 line 0 comments Download
M Source/core/css/CSSShorthands.in View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/css/FontFaceSet.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/StylePropertySerializer.cpp View 1 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 6 chunks +25 lines, -4 lines 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.cpp View 1 2 chunks +23 lines, -0 lines 0 comments Download
M Source/core/css/resolver/FontBuilder.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/resolver/FontBuilder.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 1 chunk +51 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dglazkov
lgtm
6 years, 9 months ago (2014-03-20 22:42:27 UTC) #1
eae
On 2014/03/20 22:42:27, dglazkov wrote: > lgtm I still need to figure out why it ...
6 years, 9 months ago (2014-03-20 22:43:06 UTC) #2
dglazkov
On 2014/03/20 22:43:06, eae wrote: > On 2014/03/20 22:42:27, dglazkov wrote: > > lgtm > ...
6 years, 9 months ago (2014-03-20 22:43:37 UTC) #3
esprehn
Which ASSERTs do you hit?
6 years, 7 months ago (2014-05-06 02:47:48 UTC) #4
eae
assert in StyleResolver.cpp on line 1191: template <StyleResolver::StyleApplicationPass pass> void StyleResolver::applyProperties(StyleResolverState& state, const StylePropertySet* properties, ...
6 years, 7 months ago (2014-05-06 02:52:36 UTC) #5
eae
esprehn: See https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_dbg/6627/layout-test-results/results.html for an example.
6 years, 7 months ago (2014-05-06 19:52:51 UTC) #6
eae
The CQ bit was checked by eae@chromium.org
6 years, 5 months ago (2014-07-25 03:07:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/203523002/80001
6 years, 5 months ago (2014-07-25 03:08:55 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 03:13:36 UTC) #9
Message was sent while issue was closed.
Change committed as 178893

Powered by Google App Engine
This is Rietveld 408576698