Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2035203002: Make ExternalNavigationHandler#intentsHaveSameResolvers() faster (Closed)

Created:
4 years, 6 months ago by pkotwicz
Modified:
4 years, 6 months ago
Reviewers:
Maria
CC:
chromium-reviews, Xi Han
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ExternalNavigationHandler#intentsHaveSameResolvers() faster ExternalNavigationHandler#intentsHaveSameResolvers() will be called on each WebAPK navigation. Removing the duplicate call to PackageManager#queryIntentActivities() saves 2ms per navigation. BUG=609122 TEST=None Committed: https://crrev.com/e3343a3007162a60ecffb8a242eabb9e941c7280 Cr-Commit-Position: refs/heads/master@{#398194}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java View 1 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
pkotwicz
Maria, can you please take a look?
4 years, 6 months ago (2016-06-03 23:07:06 UTC) #4
Maria
On 2016/06/03 23:07:06, pkotwicz wrote: > Maria, can you please take a look? lgtm This ...
4 years, 6 months ago (2016-06-06 18:56:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035203002/40001
4 years, 6 months ago (2016-06-07 01:11:53 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-07 01:54:12 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 01:56:25 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e3343a3007162a60ecffb8a242eabb9e941c7280
Cr-Commit-Position: refs/heads/master@{#398194}

Powered by Google App Engine
This is Rietveld 408576698