Upstream: Launch WebAPK without showing intent picker when user taps link in WebAPK scope

Upstream: Launch WebAPK without showing intent picker when user taps link in WebAPK scope

This CL surpresses the intent picker when:
- User navigates via a link
AND
- The URL falls in the scope of a WebAPK
AND
- The WebAPK is the only specialized handler for the URL

BUG=609122
TEST=ExternalNavigationHandlerTest.*

Committed: https://crrev.com/b38a7f9839a4ca2fe9032f82173462341dfd1e4b
Cr-Commit-Position: refs/heads/master@{#398946}

[pkotwicz, 2016-06-03 21:59:56]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2016-06-03 22:00:12]

pkotwicz@chromium.org changed reviewers:
+ hanxi@chromium.org

[pkotwicz, 2016-06-03 22:00:12]

Xi, can you please take a look?

[pkotwicz, 2016-06-03 22:09:24]

Patchset #1 (id:20001) has been deleted

[Xi Han, 2016-06-07 19:16:47]

https://codereview.chromium.org/2035183002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationParams.java
(right):

https://codereview.chromium.org/2035183002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationParams.java:144:
* not happening in a WebAPK.
Please align "not happening" with "Package name".

https://codereview.chromium.org/2035183002/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
(right):

https://codereview.chromium.org/2035183002/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java:801:
* without showing the intent picker.
This is because the other WebAPK is the only handler for the URL WEBAPK_SCOPE,
right? It is better to explain it clear.

[pkotwicz, 2016-06-07 22:07:07]

Xi can you please take another look?

https://codereview.chromium.org/2035183002/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
(right):

https://codereview.chromium.org/2035183002/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java:801:
* without showing the intent picker.
I changed the comment to say "solely falls into the scope". Let me know if you
have a suggestion on how to make the comment clearer

[Xi Han, 2016-06-08 14:00:11]

lgtm

Please update the CL description as:
This CL surpresses the intent picker when:
- User navigates via a link and
- The URL falls in the scope of a WebAPK and
- The WebAPK is the only specialized handler for the URL

or something that indicates to meet all of the above three conditions. Thanks!

https://codereview.chromium.org/2035183002/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
(right):

https://codereview.chromium.org/2035183002/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java:801:
* without showing the intent picker.
On 2016/06/07 22:07:07, pkotwicz wrote:
> I changed the comment to say "solely falls into the scope". Let me know if you
> have a suggestion on how to make the comment clearer

Thanks for updating the comment!

[pkotwicz, 2016-06-08 18:59:44]

Description was changed from

==========
Upstream: Launch WebAPK without showing intent picker when user taps link in
WebAPK scope

This CL surpresses the intent picker when:
- User navigates via a link
- The URL falls in the scope of a WebAPK
- The WebAPK is the only specialized handler for the URL

BUG=609122
TEST=ExternalNavigationHandlerTest.*
==========

to

==========
Upstream: Launch WebAPK without showing intent picker when user taps link in
WebAPK scope

This CL surpresses the intent picker when:
- User navigates via a link
AND
- The URL falls in the scope of a WebAPK
AND
- The WebAPK is the only specialized handler for the URL

BUG=609122
TEST=ExternalNavigationHandlerTest.*
==========

[pkotwicz, 2016-06-08 19:06:21]

pkotwicz@chromium.org changed reviewers:
+ mariakhomenko@chromium.org

[pkotwicz, 2016-06-08 19:06:21]

mariakhomenko@ can you please take a look?

This is the last WebAPK-related CL affecting ExternalNavigationHandler

In the future, we might add logic to launch a WebAPK when a user navigates to a
URL within the scope of a WebAPK via a bookmark. I am not keen on this feature
but others are. This feature is tracked in http://crbug.com/618086

[Maria, 2016-06-08 21:02:15]

lgtm

https://codereview.chromium.org/2035183002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java
(right):

https://codereview.chromium.org/2035183002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java:48:
public String findValidWebApkPackageName(List<ResolveInfo> infos);
don't need public here

https://codereview.chromium.org/2035183002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
(right):

https://codereview.chromium.org/2035183002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java:239:
String filterPackageName) {
bad indent

https://codereview.chromium.org/2035183002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java:293:
: null;
I think we typically put this one the previous line in our formatting

[pkotwicz, 2016-06-09 15:26:25]

https://codereview.chromium.org/2035183002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
(right):

https://codereview.chromium.org/2035183002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java:293:
: null;
This is the formatting done by clang-format
https://g3doc.corp.google.com/devtools/cymbal/tools/g3doc/clang-format/index....

[pkotwicz, 2016-06-09 17:19:33]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-06-09 17:19:34]

The patchset sent to the CQ was uploaded after l-g-t-m from hanxi@chromium.org,
mariakhomenko@chromium.org
Link to the patchset: https://codereview.chromium.org/2035183002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2016-06-09 17:20:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035183002/120001

[commit-bot: I haz the power, 2016-06-09 18:09:45]

Description was changed from

==========
Upstream: Launch WebAPK without showing intent picker when user taps link in
WebAPK scope

This CL surpresses the intent picker when:
- User navigates via a link
AND
- The URL falls in the scope of a WebAPK
AND
- The WebAPK is the only specialized handler for the URL

BUG=609122
TEST=ExternalNavigationHandlerTest.*
==========

to

==========
Upstream: Launch WebAPK without showing intent picker when user taps link in
WebAPK scope

This CL surpresses the intent picker when:
- User navigates via a link
AND
- The URL falls in the scope of a WebAPK
AND
- The WebAPK is the only specialized handler for the URL

BUG=609122
TEST=ExternalNavigationHandlerTest.*
==========

[commit-bot: I haz the power, 2016-06-09 18:09:46]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2016-06-09 18:10:01]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-09 18:12:54]

Description was changed from

==========
Upstream: Launch WebAPK without showing intent picker when user taps link in
WebAPK scope

This CL surpresses the intent picker when:
- User navigates via a link
AND
- The URL falls in the scope of a WebAPK
AND
- The WebAPK is the only specialized handler for the URL

BUG=609122
TEST=ExternalNavigationHandlerTest.*
==========

to

==========
Upstream: Launch WebAPK without showing intent picker when user taps link in
WebAPK scope

This CL surpresses the intent picker when:
- User navigates via a link
AND
- The URL falls in the scope of a WebAPK
AND
- The WebAPK is the only specialized handler for the URL

BUG=609122
TEST=ExternalNavigationHandlerTest.*

Committed: https://crrev.com/b38a7f9839a4ca2fe9032f82173462341dfd1e4b
Cr-Commit-Position: refs/heads/master@{#398946}
==========

[commit-bot: I haz the power, 2016-06-09 18:12:55]

Patchset 5 (id:??) landed as
https://crrev.com/b38a7f9839a4ca2fe9032f82173462341dfd1e4b
Cr-Commit-Position: refs/heads/master@{#398946}