Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Unified Diff: components/password_manager/core/browser/password_form_manager_unittest.cc

Issue 2035143002: Basic implementation of showing password fill dialog on page load (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Fix iOS compile Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager_unittest.cc
diff --git a/components/password_manager/core/browser/password_form_manager_unittest.cc b/components/password_manager/core/browser/password_form_manager_unittest.cc
index 1e36e52248015ed247f137c7208b9e7b83af045b..f2329995b2fa4a0818f17d8d222be4840236c0dc 100644
--- a/components/password_manager/core/browser/password_form_manager_unittest.cc
+++ b/components/password_manager/core/browser/password_form_manager_unittest.cc
@@ -8,6 +8,7 @@
#include <memory>
#include <utility>
+#include "base/command_line.h"
#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "base/run_loop.h"
@@ -20,6 +21,7 @@
#include "components/autofill/core/browser/test_autofill_driver.h"
#include "components/autofill/core/browser/test_personal_data_manager.h"
#include "components/autofill/core/common/autofill_pref_names.h"
+#include "components/autofill/core/common/autofill_switches.h"
#include "components/autofill/core/common/password_form.h"
#include "components/password_manager/core/browser/credentials_filter.h"
#include "components/password_manager/core/browser/mock_password_store.h"
@@ -199,6 +201,8 @@ class MockPasswordManagerDriver : public StubPasswordManagerDriver {
~MockPasswordManagerDriver() {}
MOCK_METHOD1(FillPasswordForm, void(const autofill::PasswordFormFillData&));
+ MOCK_METHOD1(ShowInitialPasswordAccountSuggestions,
+ void(const autofill::PasswordFormFillData&));
MOCK_METHOD1(AllowPasswordGenerationForForm,
void(const autofill::PasswordForm&));
@@ -678,6 +682,18 @@ class PasswordFormManagerTest : public testing::Test {
std::unique_ptr<PasswordFormManager> form_manager_;
};
+class PasswordFormManagerFillOnAccountSelectTest
+ : public PasswordFormManagerTest {
+ public:
+ PasswordFormManagerFillOnAccountSelectTest() {}
+
+ void SetUp() override {
+ base::CommandLine::ForCurrentProcess()->AppendSwitch(
+ autofill::switches::kEnableFillOnAccountSelect);
+ PasswordFormManagerTest::SetUp();
+ }
+};
+
TEST_F(PasswordFormManagerTest, TestNewLogin) {
SimulateMatchingPhase(form_manager(), RESULT_NO_MATCH);
@@ -3040,4 +3056,10 @@ TEST_F(PasswordFormManagerTest, ProbablyAccountCreationUpload) {
form_manager.Save();
}
+TEST_F(PasswordFormManagerFillOnAccountSelectTest, ProcessFrame) {
+ EXPECT_CALL(*client()->mock_driver(),
+ ShowInitialPasswordAccountSuggestions(_));
+ SimulateMatchingPhase(form_manager(), RESULT_SAVED_MATCH);
+}
+
} // namespace password_manager

Powered by Google App Engine
This is Rietveld 408576698