Basic implementation of showing password fill dialog on page load

chrome/renderer/autofill/password_autofill_agent_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <tuple>
 
+#include "base/command_line.h"
 #include "base/macros.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/renderer/autofill/password_generation_test_utils.h"
 #include "chrome/test/base/chrome_render_view_test.h"
 #include "components/autofill/content/common/autofill_messages.h"
 #include "components/autofill/content/renderer/autofill_agent.h"
 #include "components/autofill/content/renderer/form_autofill_util.h"
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 #include "components/autofill/content/renderer/test_password_autofill_agent.h"
@@ skipping 229 matching lines @@
   }
 
   // As above, but fills for an iframe.
   void SimulateOnFillPasswordFormForFrame(
       WebFrame* frame,
       const PasswordFormFillData& fill_data) {
     AutofillMsg_FillPasswordForm msg(0, kPasswordFillFormDataId, fill_data);
     content::RenderFrame::FromWebFrame(frame)->OnMessageReceived(msg);
   }
 
+  // Simulates the show initial password account suggestions message being sent
+  // to the renderer. We use that so we don't have to make
+  // RenderView::OnShowInitialPasswordAccountSuggestions() protected.
+  void SimulateOnShowInitialPasswordAccountSuggestions(
+      const PasswordFormFillData& fill_data) {
+    AutofillMsg_ShowInitialPasswordAccountSuggestions msg(
+        0, kPasswordFillFormDataId, fill_data);
+    static_cast<content::RenderFrameObserver*>(autofill_agent_)
+        ->OnMessageReceived(msg);
+  }
+
   void SendVisiblePasswordForms() {
     static_cast<content::RenderFrameObserver*>(password_autofill_agent_)
         ->DidFinishLoad();
   }
 
   void SetUp() override {
     ChromeRenderViewTest::SetUp();
 
     // Add a preferred login and an additional login to the FillData.
     username1_ = ASCIIToUTF16(kAliceUsername);
@@ skipping 1009 matching lines @@
 }
 
 // Tests that there is an autosuggestion from the password manager when the
 // user clicks on the password field when FillOnAccountSelect is enabled.
 TEST_F(PasswordAutofillAgentTest,
        FillOnAccountSelectOnlyNoCredentialsOnPasswordClick) {
   base::CommandLine::ForCurrentProcess()->AppendSwitch(
       autofill::switches::kEnableFillOnAccountSelect);
 
   // Simulate the browser sending back the login info.
-  SimulateOnFillPasswordForm(fill_data_);
+  SimulateOnShowInitialPasswordAccountSuggestions(fill_data_);
 
   // Clear the text fields to start fresh.
   ClearUsernameAndPasswordFields();
 
   // Call SimulateElementClick() to produce a user gesture on the page so
   // autofill will actually fill.
   SimulateElementClick(kUsernameName);
 
   // Simulate a user clicking on the password element. This should produce no
   // message.
   render_thread_->sink().ClearMessages();
   static_cast<PageClickListener*>(autofill_agent_)
       ->FormControlElementClicked(password_element_, false);
   EXPECT_TRUE(render_thread_->sink().GetFirstMessageMatching(
       AutofillHostMsg_ShowPasswordSuggestions::ID));
 }
 
 // Tests the autosuggestions that are given when a password element is clicked,
 // the username element is not editable, and FillOnAccountSelect is enabled.
 // Specifically, tests when the user clicks on the password element after page
 // load, and the corresponding username element is readonly (and thus
 // uneditable), that the credentials for the already-filled username are
 // suggested.
 TEST_F(PasswordAutofillAgentTest,
        FillOnAccountSelectOnlyCredentialsOnPasswordClick) {
   base::CommandLine::ForCurrentProcess()->AppendSwitch(
       autofill::switches::kEnableFillOnAccountSelect);
 
   // Simulate the browser sending back the login info.
-  SimulateOnFillPasswordForm(fill_data_);
+  SimulateOnShowInitialPasswordAccountSuggestions(fill_data_);
 
   // Clear the text fields to start fresh.
   ClearUsernameAndPasswordFields();
 
   // Simulate the page loading with a prefilled username element that is
   // uneditable.
   username_element_.setValue("alicia");
   SetElementReadOnly(username_element_, true);
 
   // Call SimulateElementClick() to produce a user gesture on the page so
@@ skipping 231 matching lines @@
   CheckTextFieldsState("", false, "", false);
 }
 
 TEST_F(PasswordAutofillAgentTest, FillOnAccountSelectOnly) {
   base::CommandLine::ForCurrentProcess()->AppendSwitch(
       autofill::switches::kEnableFillOnAccountSelect);
 
   ClearUsernameAndPasswordFields();
 
   // Simulate the browser sending back the login info for an initial page load.
-  SimulateOnFillPasswordForm(fill_data_);
+  SimulateOnShowInitialPasswordAccountSuggestions(fill_data_);
 
-  CheckTextFieldsState(std::string(), true, std::string(), false);
+  CheckTextFieldsState(std::string(), false, std::string(), false);
+  CheckSuggestions(std::string(), true);
 }
 
 TEST_F(PasswordAutofillAgentTest, FillOnAccountSelectOnlyReadonlyUsername) {
   base::CommandLine::ForCurrentProcess()->AppendSwitch(
       autofill::switches::kEnableFillOnAccountSelect);
 
   ClearUsernameAndPasswordFields();
 
   username_element_.setValue("alice");
   SetElementReadOnly(username_element_, true);
 
   // Simulate the browser sending back the login info for an initial page load.
-  SimulateOnFillPasswordForm(fill_data_);
+  SimulateOnShowInitialPasswordAccountSuggestions(fill_data_);
 
-  CheckTextFieldsState(std::string("alice"), false, std::string(), true);
+  CheckTextFieldsState(std::string("alice"), false, std::string(), false);
 }
 
 TEST_F(PasswordAutofillAgentTest,
        FillOnAccountSelectOnlyReadonlyNotPreferredUsername) {
   base::CommandLine::ForCurrentProcess()->AppendSwitch(
       autofill::switches::kEnableFillOnAccountSelect);
 
   ClearUsernameAndPasswordFields();
 
   username_element_.setValue("Carol");
   SetElementReadOnly(username_element_, true);
 
   // Simulate the browser sending back the login info for an initial page load.
-  SimulateOnFillPasswordForm(fill_data_);
+  SimulateOnShowInitialPasswordAccountSuggestions(fill_data_);
 
-  CheckTextFieldsState(std::string("Carol"), false, std::string(), true);
+  CheckTextFieldsState(std::string("Carol"), false, std::string(), false);
 }
 
 TEST_F(PasswordAutofillAgentTest, FillOnAccountSelectOnlyNoUsername) {
   base::CommandLine::ForCurrentProcess()->AppendSwitch(
       autofill::switches::kEnableFillOnAccountSelect);
 
   // Load a form with no username and update test data.
   LoadHTML(kVisibleFormWithNoUsernameHTML);
   username_element_.reset();
   WebDocument document = GetMainFrame()->document();
   WebElement element =
       document.getElementById(WebString::fromUTF8(kPasswordName));
   ASSERT_FALSE(element.isNull());
   password_element_ = element.to<blink::WebInputElement>();
   fill_data_.username_field = FormFieldData();
   UpdateOriginForHTML(kVisibleFormWithNoUsernameHTML);
   fill_data_.additional_logins.clear();
   fill_data_.other_possible_usernames.clear();
 
   password_element_.setValue("");
   password_element_.setAutofilled(false);
 
   // Simulate the browser sending back the login info for an initial page load.
-  SimulateOnFillPasswordForm(fill_data_);
+  SimulateOnShowInitialPasswordAccountSuggestions(fill_data_);
 
   EXPECT_TRUE(password_element_.suggestedValue().isEmpty());
-  EXPECT_TRUE(password_element_.isAutofilled());
+  EXPECT_FALSE(password_element_.isAutofilled());
+  CheckSuggestions(std::string(), false);
 }
 
 TEST_F(PasswordAutofillAgentTest, ShowPopupOnEmptyPasswordField) {
   // Load a form with no username and update test data.
   LoadHTML(kVisibleFormWithNoUsernameHTML);
   username_element_.reset();
   WebDocument document = GetMainFrame()->document();
   WebElement element =
       document.getElementById(WebString::fromUTF8(kPasswordName));
   ASSERT_FALSE(element.isNull());
@@ skipping 721 matching lines @@
   EXPECT_FALSE(render_thread_->sink().GetFirstMessageMatching(
       AutofillHostMsg_ShowPasswordSuggestions::ID));
 
   // But when the user clicks on the autofilled password field again it should
   // still produce a suggestion dropdown.
   SimulateElementClick("password");
   CheckSuggestions("", false);
 }
 
 }  // namespace autofill