third_party/WebKit/Source/core/frame/ImageBitmap.h - Issue 2035113002: Implement ImageBitmapOptions resize

Unified Diff: third_party/WebKit/Source/core/frame/ImageBitmap.h

Issue 2035113002: Implement ImageBitmapOptions resize (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-resize.html ('K') | « third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-resize.html ('k') | third_party/WebKit/Source/core/frame/ImageBitmap.cpp » ('j') | third_party/WebKit/Source/core/frame/ImageBitmap.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/ImageBitmap.h

diff --git a/third_party/WebKit/Source/core/frame/ImageBitmap.h b/third_party/WebKit/Source/core/frame/ImageBitmap.h

index bb5aa15194715dee7716fe4fbb397b23429b68e9..d2406b8f70cb10f4a06d9f520e91f6486daabf2f 100644

--- a/third_party/WebKit/Source/core/frame/ImageBitmap.h

+++ b/third_party/WebKit/Source/core/frame/ImageBitmap.h

@@ -51,6 +51,8 @@ public:

// isImageBitmapOriginClean indicates whether the original ImageBitmap is origin clean or not.

static ImageBitmap* create(std::unique_ptr<uint8_t[]> data, uint32_t width, uint32_t height, bool isImageBitmapPremultiplied, bool isImageBitmapOriginClean);

static PassRefPtr<SkImage> getSkImageFromDecoder(std::unique_ptr<ImageDecoder>);

+ static bool isResizeOptionValid(const ImageBitmapOptions&, ExceptionState&);

+ static bool isSWSHValid(int sw, int sh, ExceptionState&);

// Type and helper function required by CallbackPromiseAdapter:

using WebType = sk_sp<SkImage>;

@@ -87,18 +89,16 @@ public:

DECLARE_VIRTUAL_TRACE();

private:

- ImageBitmap(HTMLImageElement*, const IntRect&, Document*, const ImageBitmapOptions&);

- ImageBitmap(HTMLVideoElement*, const IntRect&, Document*, const ImageBitmapOptions&);

- ImageBitmap(HTMLCanvasElement*, const IntRect&, const ImageBitmapOptions&);

- ImageBitmap(ImageData*, const IntRect&, const ImageBitmapOptions&);

- ImageBitmap(ImageBitmap*, const IntRect&, const ImageBitmapOptions&);

+ ImageBitmap(HTMLImageElement*, IntRect&, Document*, const ImageBitmapOptions&);

+ ImageBitmap(HTMLVideoElement*, IntRect&, Document*, const ImageBitmapOptions&);

+ ImageBitmap(HTMLCanvasElement*, IntRect&, const ImageBitmapOptions&);

+ ImageBitmap(ImageData*, IntRect&, const ImageBitmapOptions&);

+ ImageBitmap(ImageBitmap*, IntRect&, const ImageBitmapOptions&);

ImageBitmap(PassRefPtr<StaticBitmapImage>);

- ImageBitmap(PassRefPtr<StaticBitmapImage>, const IntRect&, const ImageBitmapOptions&);

+ ImageBitmap(PassRefPtr<StaticBitmapImage>, IntRect&, const ImageBitmapOptions&);

ImageBitmap(WebExternalTextureMailbox&);

ImageBitmap(std::unique_ptr<uint8_t[]> data, uint32_t width, uint32_t height, bool isImageBitmapPremultiplied, bool isImageBitmapOriginClean);

- void parseOptions(const ImageBitmapOptions&, bool&, bool&);

RefPtr<StaticBitmapImage> m_image;

bool m_isNeutered = false;

};