Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(29)

Issue 2035103002: Make the getting started section in the README better (Closed)

Created:
4 years, 3 months ago by Ted Mielczarek
Modified:
4 years, 3 months ago
Reviewers:
vapier
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make the getting started section in the README better Some of my colleagues have commented in the past few months that the Breakpad README is not very clear on how to get and build the code nowadays. This change moves some of the docs from the "request change review" section up to the "getting started" section, and adds a few more things to clarify. R=vapier@chromium.org BUG= Committed: https://chromium.googlesource.com/breakpad/breakpad/+/8b7b28663f679c2ad71a263f7491f1eb316f667b

Patch Set 1 #

Total comments: 12

Patch Set 2 : Add a missing cd #

Patch Set 3 : Fix review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -22 lines) Patch
M README.md View 1 2 1 chunk +52 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Ted Mielczarek
4 years, 3 months ago (2016-06-03 14:50:46 UTC) #1
vapier
you can upload the CL to gerrit and verify gitiles there: git push origin HEAD:refs/for/master ...
4 years, 3 months ago (2016-06-03 14:58:36 UTC) #2
Ted Mielczarek
https://codereview.chromium.org/2035103002/diff/1/README.md File README.md (right): https://codereview.chromium.org/2035103002/diff/1/README.md#newcode13 README.md:13: ## Getting started (from trunk) On 2016/06/03 14:58:35, vapier ...
4 years, 3 months ago (2016-06-03 16:40:40 UTC) #3
Ted Mielczarek
On 2016/06/03 14:58:36, vapier wrote: > you can upload the CL to gerrit and verify ...
4 years, 3 months ago (2016-06-03 16:41:41 UTC) #4
vapier
lgtm
4 years, 3 months ago (2016-06-03 17:21:05 UTC) #5
Ted Mielczarek
4 years, 3 months ago (2016-06-03 17:32:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
8b7b28663f679c2ad71a263f7491f1eb316f667b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698