Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: Source/bindings/scripts/deprecated_code_generator_v8.pm

Issue 20351002: Add 'error' parameter to 'window.onerror' handlers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Feedback. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/deprecated_code_generator_v8.pm
diff --git a/Source/bindings/scripts/deprecated_code_generator_v8.pm b/Source/bindings/scripts/deprecated_code_generator_v8.pm
index d49ce7ef64eb85e1da4c90c794b23ada80e61206..f035e29bef9a38661f48b406eef87b2d9b5f5ba5 100644
--- a/Source/bindings/scripts/deprecated_code_generator_v8.pm
+++ b/Source/bindings/scripts/deprecated_code_generator_v8.pm
@@ -2616,9 +2616,13 @@ sub GenerateEventConstructor
my $v8ClassName = GetV8ClassName($interface);
my @anyAttributeNames;
+ my @serializableAnyAttributeNames;
foreach my $attribute (@{$interface->attributes}) {
if ($attribute->type eq "any") {
push(@anyAttributeNames, $attribute->name);
+ if (!$attribute->extendedAttributes->{"Unserializable"}) {
+ push(@serializableAnyAttributeNames, $attribute->name);
+ }
}
}
@@ -2661,12 +2665,12 @@ END
RefPtr<${implClassName}> event = ${implClassName}::create(type, eventInit);
END
- if (@anyAttributeNames) {
+ if (@serializableAnyAttributeNames) {
# If we're in an isolated world, create a SerializedScriptValue and store it in the event for
# later cloning if the property is accessed from another world.
# The main world case is handled lazily (in Custom code).
$implementation{nameSpaceInternal}->add(" if (isolatedWorldForIsolate(args.GetIsolate())) {\n");
- foreach my $attrName (@anyAttributeNames) {
+ foreach my $attrName (@serializableAnyAttributeNames) {
my $setter = "setSerialized" . FirstLetterToUpperCase($attrName);
$implementation{nameSpaceInternal}->add(<<END);
if (!${attrName}.IsEmpty())

Powered by Google App Engine
This is Rietveld 408576698