Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: Source/core/dom/ErrorEvent.h

Issue 20351002: Add 'error' parameter to 'window.onerror' handlers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fixes. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/ErrorEvent.h
diff --git a/Source/core/dom/ErrorEvent.h b/Source/core/dom/ErrorEvent.h
index a28dcbef2a1e81300849935046f502bf0a8e94db..124b502f197196aac9aa74ca13facd954dcc52c5 100644
--- a/Source/core/dom/ErrorEvent.h
+++ b/Source/core/dom/ErrorEvent.h
@@ -31,7 +31,10 @@
#ifndef ErrorEvent_h
#define ErrorEvent_h
+#include "bindings/v8/ScriptValue.h"
+#include "bindings/v8/SerializedScriptValue.h"
#include "core/dom/Event.h"
+#include "wtf/RefPtr.h"
#include "wtf/text/WTFString.h"
namespace WebCore {
@@ -43,6 +46,7 @@ struct ErrorEventInit : public EventInit {
String filename;
unsigned lineno;
unsigned colno;
+ ScriptValue error;
adamk 2013/07/31 16:37:30 I asked before but I don't think I got an answer:
Mike West 2013/08/01 07:52:15 Nothing! Killed it.
};
class ErrorEvent : public Event {
@@ -59,6 +63,10 @@ public:
{
return adoptRef(new ErrorEvent(type, initializer));
}
+ static PassRefPtr<ErrorEvent> createSanitizedError()
+ {
+ return adoptRef(new ErrorEvent("Script error.", String(), 0, 0));
+ }
virtual ~ErrorEvent();
const String& message() const { return m_message; }
@@ -66,6 +74,8 @@ public:
unsigned lineno() const { return m_lineNumber; }
unsigned colno() const { return m_columnNumber; }
+ void setSerializedError(PassRefPtr<SerializedScriptValue>) { }
adamk 2013/07/31 16:37:30 I thought you were going to add something to the c
Mike West 2013/08/01 07:52:15 I was! And I have!
+
virtual const AtomicString& interfaceName() const;
private:
@@ -73,6 +83,7 @@ private:
ErrorEvent(const String& message, const String& fileName, unsigned lineNumber, unsigned columnNumber);
ErrorEvent(const AtomicString&, const ErrorEventInit&);
+
dcarney 2013/07/30 18:51:58 nit: space
String m_message;
String m_fileName;
unsigned m_lineNumber;

Powered by Google App Engine
This is Rietveld 408576698