Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: LayoutTests/fast/events/resources/onerror-test.js

Issue 20351002: Add 'error' parameter to 'window.onerror' handlers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/events/window-onerror-01-expected.txt » ('j') | Source/core/dom/ErrorEvent.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/events/resources/onerror-test.js
diff --git a/LayoutTests/fast/events/resources/onerror-test.js b/LayoutTests/fast/events/resources/onerror-test.js
index 1016aa201081576947532187954f43b99b8fbb74..50beff3d23d37804c419f25f1c85c15ba639cd07 100644
--- a/LayoutTests/fast/events/resources/onerror-test.js
+++ b/LayoutTests/fast/events/resources/onerror-test.js
@@ -8,8 +8,10 @@ function throwException(message) {
var errorsSeen = 0;
function dumpOnErrorArgumentValuesAndReturn(returnValue, callback) {
- window.onerror = function (message, url, line, column) {
+ window.onerror = function (message, url, line, column, error) {
debug("window.onerror: \"" + message + "\" at " + stripURL(url) + " (Line: " + line + ", Column: " + column + ")");
+ if (error)
+ debug(stripStackURLs(error.stack));
if (callback)
callback(++errorsSeen);
@@ -44,6 +46,8 @@ var eventPassedToTheErrorListener = null;
var eventCurrentTarget = null;
function dumpErrorEvent(e) {
debug("Handling '" + e.type + "' event (phase " + e.eventPhase + "): \"" + e.message + "\" at " + stripURL(e.filename) + ":" + e.lineno);
+ if (e.error)
+ debug(stripStackURLs(e.error.stack));
eventPassedToTheErrorListener = e;
eventCurrentTarget = e.currentTarget;
@@ -52,3 +56,13 @@ function dumpErrorEvent(e) {
eventPassedToTheErrorListener = null;
eventCurrentTarget = null;
}
+
+function stripStackURLs(stackTrace) {
+ var text = stackTrace + "\n\n";
+ stackTrace = stackTrace.split("\n");
+ var length = Math.min(stackTrace.length, 100);
+ for (var i = 0; i < length; i++) {
+ text += stackTrace[i].replace(/at ((?:eval at \()?[a-zA-Z\.]+ )?\(?.+\/([^\/]+):(\d+):(\d+)\)?/, "at $1$2:$3:$4") + "\n";
+ }
+ return text;
+}
« no previous file with comments | « no previous file | LayoutTests/fast/events/window-onerror-01-expected.txt » ('j') | Source/core/dom/ErrorEvent.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698