Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2035083003: mac/gn: Build performance_browser_tests (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 6 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac/gn: Build performance_browser_tests With this, all *tests binaries built in the gyp build are also built in the gn build on Mac (except remoting). Also remove an unused js2webui rule in the gyp version of the target: The target doesn't contain any .js files. BUG=431177 Committed: https://crrev.com/50bcf83ca74dba33f56ac8678c9359a92528272a Cr-Commit-Position: refs/heads/master@{#397784}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -38 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -37 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
4 years, 6 months ago (2016-06-03 16:12:53 UTC) #2
Robert Sesek
lgtm
4 years, 6 months ago (2016-06-03 17:33:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035083003/1
4 years, 6 months ago (2016-06-03 17:48:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 20:05:37 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 20:06:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50bcf83ca74dba33f56ac8678c9359a92528272a
Cr-Commit-Position: refs/heads/master@{#397784}

Powered by Google App Engine
This is Rietveld 408576698