Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Issue 2035073002: Fix speculative inlining in precompilation. (Closed)

Created:
4 years, 6 months ago by Florian Schneider
Modified:
4 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix speculative inlining in precompilation. When optimistically inlining is-checks and as-casts, we have to guard again repeated speculative attempts. Also, add result cid information for recognized factories. BUG=#26607 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/9ee5dfb2451e294555f8b3320a1580f9bc315859

Patch Set 1 #

Patch Set 2 : update status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M runtime/vm/aot_optimizer.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Florian Schneider
4 years, 6 months ago (2016-06-03 12:49:15 UTC) #3
rmacnak
lgtm
4 years, 6 months ago (2016-06-03 17:32:15 UTC) #4
Florian Schneider
4 years, 6 months ago (2016-06-06 23:37:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9ee5dfb2451e294555f8b3320a1580f9bc315859 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698