Split RenderViewContextMenu code into functions

Split RenderViewContextMenu code into functions

This should be a behavior no-op. The nontrivial "is enabled" and "execute"
commands are now split into helper functions using a consistent style. This
helps make the multi-hundred-line-long switch statements more manageable.

Committed: https://crrev.com/49542531ab22beff15960f60d6b8c9398234d4ce
Cr-Commit-Position: refs/heads/master@{#398094}

[brettw, 2016-06-03 23:06:23]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-03 23:07:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035033003/1

[commit-bot: I haz the power, 2016-06-04 00:43:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-04 00:43:58]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-06-06 17:58:53]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-06 17:59:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035033003/40001

[brettw, 2016-06-06 18:00:11]

brettw@chromium.org changed reviewers:
+ rouslan@chromium.org

[brettw, 2016-06-06 18:00:11]

Low priority. I had to change this code for an OOPIF patch and I was annoyed at
the switch statements being out of control.

[please use gerrit instead, 2016-06-06 18:17:34]

Description was changed from

==========
Split RenderViewContextMenu code into functions

This should be a behavior no-op. The nontrivial "is enabled" and "execute"
commands are now split into helper functions using a consistent style. This
helps make the multi-hundren-line-long switch statements more manageable.
==========

to

==========
Split RenderViewContextMenu code into functions

This should be a behavior no-op. The nontrivial "is enabled" and "execute"
commands are now split into helper functions using a consistent style. This
helps make the multi-hundred-line-long switch statements more manageable.
==========

[please use gerrit instead, 2016-06-06 18:18:12]

lgtm this huge mostly mechanical patch. +1 the file is more readable now.

[brettw, 2016-06-06 19:05:21]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2016-06-06 19:05:26]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-06-06 19:06:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035033003/40001

[commit-bot: I haz the power, 2016-06-06 19:38:45]

Description was changed from

==========
Split RenderViewContextMenu code into functions

This should be a behavior no-op. The nontrivial "is enabled" and "execute"
commands are now split into helper functions using a consistent style. This
helps make the multi-hundred-line-long switch statements more manageable.
==========

to

==========
Split RenderViewContextMenu code into functions

This should be a behavior no-op. The nontrivial "is enabled" and "execute"
commands are now split into helper functions using a consistent style. This
helps make the multi-hundred-line-long switch statements more manageable.
==========

[commit-bot: I haz the power, 2016-06-06 19:38:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-06 19:41:48]

Description was changed from

==========
Split RenderViewContextMenu code into functions

This should be a behavior no-op. The nontrivial "is enabled" and "execute"
commands are now split into helper functions using a consistent style. This
helps make the multi-hundred-line-long switch statements more manageable.
==========

to

==========
Split RenderViewContextMenu code into functions

This should be a behavior no-op. The nontrivial "is enabled" and "execute"
commands are now split into helper functions using a consistent style. This
helps make the multi-hundred-line-long switch statements more manageable.

Committed: https://crrev.com/49542531ab22beff15960f60d6b8c9398234d4ce
Cr-Commit-Position: refs/heads/master@{#398094}
==========

[commit-bot: I haz the power, 2016-06-06 19:41:49]

Patchset 3 (id:??) landed as
https://crrev.com/49542531ab22beff15960f60d6b8c9398234d4ce
Cr-Commit-Position: refs/heads/master@{#398094}