Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Unified Diff: media/filters/frame_processor.h

Issue 2035003002: MSE: Signal new coded frame group more aggressively (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed chcunningham@'s comments from PS5 Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/filters/frame_processor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/frame_processor.h
diff --git a/media/filters/frame_processor.h b/media/filters/frame_processor.h
index 0a1ecc641858840226f4ac11b1160de591a5bd4e..158b25b7aa0dd6c9cf35f8e609068e1a49da132e 100644
--- a/media/filters/frame_processor.h
+++ b/media/filters/frame_processor.h
@@ -152,11 +152,17 @@ class MEDIA_EXPORT FrameProcessor {
// set to false ("segments").
bool sequence_mode_ = false;
- // Flag to track whether or not the next processed frame is a continuation of
- // a coded frame group. This flag resets to false upon detection of
- // discontinuity, and becomes true once a processed coded frame for the
- // current coded frame group is sent to its track buffer.
- bool in_coded_frame_group_ = false;
+ // Tracks whether or not the next processed frame is a continuation of a coded
+ // frame group (see https://w3c.github.io/media-source/#coded-frame-group).
+ // Resets to kNoDecodeTimestamp() upon detection of 'segments' mode
+ // discontinuity, parser reset during 'segments' mode, or switching from
+ // 'sequence' to 'segments' mode.
+ // Once a processed coded frame is emitted for the current coded frame group,
+ // tracks the decode timestamp of the last frame emitted.
+ // Explicit setting of timestampOffset will trigger subsequent notification of
+ // a new coded frame start to the tracks' streams, even in 'sequence' mode, if
+ // the resulting frame has a DTS less than this.
+ DecodeTimestamp coded_frame_group_last_dts_ = kNoDecodeTimestamp();
// Tracks the MSE coded frame processing variable of same name.
// Initially kNoTimestamp(), meaning "unset".
« no previous file with comments | « no previous file | media/filters/frame_processor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698