|
Handle deferred access of unserialized code.
This CL fixes crashes in deferred_load when using serialized dart:core:
- resolution impacts are cached in [Resolution] for both serialized and unserialized elements.
- type variable constants (for mirrors) are computed using [ConstantExpression]s.
- LibraryElementZ.getImportsFor returns the empty list; thus still not valid for deferred access in serialized code.
R=sigmund@google.com
Committed: https://github.com/dart-lang/sdk/commit/0b926d64a477e60ece9fa15099d0ec3caa05d217
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+72 lines, -55 lines) |
Patch |
|
M |
pkg/compiler/lib/src/common/resolution.dart
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
pkg/compiler/lib/src/compiler.dart
|
View
|
1
|
1 chunk |
+10 lines, -3 lines |
0 comments
|
Download
|
|
M |
pkg/compiler/lib/src/constants/expressions.dart
|
View
|
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
pkg/compiler/lib/src/deferred_load.dart
|
View
|
|
1 chunk |
+7 lines, -0 lines |
0 comments
|
Download
|
|
M |
pkg/compiler/lib/src/js_backend/type_variable_handler.dart
|
View
|
1
|
2 chunks |
+12 lines, -32 lines |
0 comments
|
Download
|
|
M |
pkg/compiler/lib/src/resolution/members.dart
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
pkg/compiler/lib/src/resolution/resolution.dart
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
pkg/compiler/lib/src/serialization/equivalence.dart
|
View
|
1
|
1 chunk |
+4 lines, -1 line |
0 comments
|
Download
|
|
M |
pkg/compiler/lib/src/serialization/modelz.dart
|
View
|
1
|
2 chunks |
+10 lines, -3 lines |
0 comments
|
Download
|
|
M |
pkg/compiler/lib/src/serialization/system.dart
|
View
|
1
|
4 chunks |
+7 lines, -10 lines |
0 comments
|
Download
|
|
M |
pkg/compiler/lib/src/serialization/task.dart
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
tests/compiler/dart2js/mock_libraries.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
tests/compiler/dart2js/serialization/test_data.dart
|
View
|
|
1 chunk |
+12 lines, -0 lines |
0 comments
|
Download
|
Total messages: 5 (2 generated)
|