Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2034973003: Handle deferred access of unserialized code. (Closed)

Created:
4 years, 6 months ago by Johnni Winther
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle deferred access of unserialized code. This CL fixes crashes in deferred_load when using serialized dart:core: - resolution impacts are cached in [Resolution] for both serialized and unserialized elements. - type variable constants (for mirrors) are computed using [ConstantExpression]s. - LibraryElementZ.getImportsFor returns the empty list; thus still not valid for deferred access in serialized code. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/0b926d64a477e60ece9fa15099d0ec3caa05d217

Patch Set 1 #

Patch Set 2 : dartfmt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -55 lines) Patch
M pkg/compiler/lib/src/common/resolution.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 1 chunk +10 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/type_variable_handler.dart View 1 2 chunks +12 lines, -32 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 2 chunks +10 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/serialization/system.dart View 1 4 chunks +7 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/serialization/task.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/mock_libraries.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/test_data.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 6 months ago (2016-06-03 09:17:14 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 6 months ago (2016-06-03 17:38:37 UTC) #3
Johnni Winther
4 years, 6 months ago (2016-06-06 08:26:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0b926d64a477e60ece9fa15099d0ec3caa05d217 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698