Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Unified Diff: tests/ImageTest.cpp

Issue 2034933003: Store mipmap levels in deferred texture image (Closed) Base URL: https://skia.googlesource.com/skia.git@pipe-mipmap-levels-to-creation
Patch Set: Fixing Windows build. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/image/SkImage_Gpu.cpp ('K') | « src/image/SkImage_Gpu.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/ImageTest.cpp
diff --git a/tests/ImageTest.cpp b/tests/ImageTest.cpp
index 0922364d0fda07742188528c36c1c4ee9a028a3a..233d4a3af144b530f4eea9ad1b5ff17c64c3bc98 100644
--- a/tests/ImageTest.cpp
+++ b/tests/ImageTest.cpp
@@ -863,7 +863,8 @@ DEF_GPUTEST_FOR_RENDERING_CONTEXTS(DeferredTextureImage, reporter, ctxInfo) {
params.fQuality = kLow_SkFilterQuality;
params.fMatrix = SkMatrix::I();
- size_t size = image->getDeferredTextureImageData(*proxy, &params, 1, nullptr);
+ size_t size = image->getDeferredTextureImageData(*proxy, &params, 1, nullptr,
+ SkSourceGammaTreatment::kRespect);
static const char *const kFS[] = { "fail", "succeed" };
if (SkToBool(size) != testCase.fExpectation) {
@@ -873,10 +874,12 @@ DEF_GPUTEST_FOR_RENDERING_CONTEXTS(DeferredTextureImage, reporter, ctxInfo) {
if (size) {
void* buffer = sk_malloc_throw(size);
void* misaligned = reinterpret_cast<void*>(reinterpret_cast<intptr_t>(buffer) + 3);
- if (image->getDeferredTextureImageData(*proxy, &params, 1, misaligned)) {
+ if (image->getDeferredTextureImageData(*proxy, &params, 1, misaligned,
+ SkSourceGammaTreatment::kRespect)) {
ERRORF(reporter, "Should fail when buffer is misaligned.");
}
- if (!image->getDeferredTextureImageData(*proxy, &params, 1, buffer)) {
+ if (!image->getDeferredTextureImageData(*proxy, &params, 1, buffer,
+ SkSourceGammaTreatment::kRespect)) {
ERRORF(reporter, "deferred image size succeeded but creation failed.");
} else {
for (auto budgeted : { SkBudgeted::kNo, SkBudgeted::kYes }) {
« src/image/SkImage_Gpu.cpp ('K') | « src/image/SkImage_Gpu.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698